Skip to content

[Merged by Bors] - feat(Analysis/Pow/Deriv): add some results about differentiability of cpow#19944

Closed
xroblot wants to merge 6 commits intomasterfrom
xfr-cpow_deriv
Closed

[Merged by Bors] - feat(Analysis/Pow/Deriv): add some results about differentiability of cpow#19944
xroblot wants to merge 6 commits intomasterfrom
xfr-cpow_deriv

Conversation

@xroblot
Copy link
Copy Markdown
Collaborator

@xroblot xroblot commented Dec 13, 2024

  • Add several results that exists for rpow but not for cpow:
    • DifferentiableAt.cpow_const, DifferentiableWithinAt.cpow_const and DifferentiableOn.cpow_const about the differentiability of z ↦ (f z) ^ c
    • Complex.deriv_cpow_const and deriv_cpow_const for computing deriv
  • Add also an alternate version of hasDerivAt_ofReal_cpow on the differentiability of fun y : ℝ => (y : ℂ) ^ c and the corresponding DifferentiableAt and deriv results that follow.

  • Add the equivalent for fun y : ℝ => (y : ℂ) ^ c of isTheta_deriv_rpow_const_atTop and isBigO_deriv_rpow_const_atTop

This PR doesn't add new maths since all the results proved are direct consequences of existing results.


Open in Gitpod

@xroblot xroblot changed the title feat(Analysis/Pow/Deriv): add missing results for cpow_const feat(Analysis/Pow/Deriv): add missing results about differentiability of cpow Dec 13, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 13, 2024

PR summary 730d290478

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Complex.deriv_cpow_const
+ Complex.deriv_ofReal_cpow_const
+ DifferentiableAt.cpow_const
+ DifferentiableAt.ofReal_cpow_const
+ DifferentiableOn.cpow_const
+ DifferentiableWithinAt.cpow_const
+ deriv_cpow_const
+ hasDerivAt_ofReal_cpow_const
+ hasDerivAt_ofReal_cpow_const'
+ isBigO_deriv_ofReal_cpow_const_atTop
+ isTheta_deriv_ofReal_cpow_const_atTop

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Dec 13, 2024
xroblot

This comment was marked as off-topic.

@xroblot xroblot changed the title feat(Analysis/Pow/Deriv): add missing results about differentiability of cpow feat(Analysis/Pow/Deriv): add some results about differentiability of cpow Dec 13, 2024
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all seem good to have, but I have questions about the colour of the bikeshed names

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 14, 2024
@xroblot xroblot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 15, 2024
@xroblot
Copy link
Copy Markdown
Collaborator Author

xroblot commented Jan 6, 2025

@Ruben-VandeVelde are you okay with the new names?

Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 14, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 20, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 20, 2025
… cpow (#19944)

* Add several results that exists for `rpow` but not for `cpow`:

- * `DifferentiableAt.cpow_const`, `DifferentiableWithinAt.cpow_const` and `DifferentiableOn.cpow_const` about the differentiability of `z ↦ (f z) ^ c`
- * `Complex.deriv_cpow_const` and `deriv_cpow_const` for computing `deriv`

* Add also an alternate version of `hasDerivAt_ofReal_cpow` on the differentiability of `fun y : ℝ => (y : ℂ) ^ c` and the corresponding `DifferentiableAt` and `deriv` results that follow.

* Add the equivalent for `fun y : ℝ => (y : ℂ) ^ c` of `isTheta_deriv_rpow_const_atTop` and `isBigO_deriv_rpow_const_atTop`

This PR doesn't add new maths since all the results proved are direct consequences of existing results.



Co-authored-by: Xavier Roblot <46200072+xroblot@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 20, 2025

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jan 20, 2025
… cpow (#19944)

* Add several results that exists for `rpow` but not for `cpow`:

- * `DifferentiableAt.cpow_const`, `DifferentiableWithinAt.cpow_const` and `DifferentiableOn.cpow_const` about the differentiability of `z ↦ (f z) ^ c`
- * `Complex.deriv_cpow_const` and `deriv_cpow_const` for computing `deriv`

* Add also an alternate version of `hasDerivAt_ofReal_cpow` on the differentiability of `fun y : ℝ => (y : ℂ) ^ c` and the corresponding `DifferentiableAt` and `deriv` results that follow.

* Add the equivalent for `fun y : ℝ => (y : ℂ) ^ c` of `isTheta_deriv_rpow_const_atTop` and `isBigO_deriv_rpow_const_atTop`

This PR doesn't add new maths since all the results proved are direct consequences of existing results.



Co-authored-by: Xavier Roblot <46200072+xroblot@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jan 20, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Analysis/Pow/Deriv): add some results about differentiability of cpow [Merged by Bors] - feat(Analysis/Pow/Deriv): add some results about differentiability of cpow Jan 20, 2025
@mathlib-bors mathlib-bors bot closed this Jan 20, 2025
@mathlib-bors mathlib-bors bot deleted the xfr-cpow_deriv branch January 20, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants