[Merged by Bors] - feat(Probability/Distributions/Gaussian): the mgf of a gaussian#19896
Closed
[Merged by Bors] - feat(Probability/Distributions/Gaussian): the mgf of a gaussian#19896
Conversation
PR summary 33929dffdb
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Probability.Distributions.Gaussian | 2103 | 2110 | +7 (+0.33%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Probability.Distributions.Gaussian |
7 |
Declarations diff
+ _root_.AEMeasurable.of_map_ne_zero
+ cgf_gaussianReal
+ mgf_add_const
+ mgf_const_add
+ mgf_dirac
+ mgf_gaussianReal
+ mgf_id_map
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
RemyDegenne
reviewed
Dec 11, 2024
Contributor
RemyDegenne
left a comment
There was a problem hiding this comment.
Can you also add a lemma (in this PR) for the mgf of a general gaussianReal and also add cgf versions?
RemyDegenne
reviewed
Dec 20, 2024
Collaborator
Author
|
I am now computing the mgf of a general gaussian, and I added the cgf too. |
RemyDegenne
reviewed
Dec 21, 2024
Collaborator
Author
|
I added the lemma |
YaelDillies
reviewed
Dec 31, 2024
YaelDillies
reviewed
Jan 1, 2025
Vilin97
commented
Jan 1, 2025
Contributor
|
This looks good to me. I'll let maintainers decide about #19896 (comment) maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
eric-wieser
reviewed
Jan 2, 2025
Contributor
|
This looks ready to go. Please fix the conflict and ping me for a merge. |
RemyDegenne
reviewed
Jan 2, 2025
Contributor
|
Thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
Compute the mgf of a gaussian. Co-authored-by: Siyuan Ge <jamesgsy@uw.edu> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded! And happy new year! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute the mgf of a gaussian.
Co-authored-by: Siyuan Ge jamesgsy@uw.edu