Skip to content

[Merged by Bors] - chore(Radical): minor refactoring of lemmas#19875

Closed
seewoo5 wants to merge 2 commits intomasterfrom
feature/radical-refactor
Closed

[Merged by Bors] - chore(Radical): minor refactoring of lemmas#19875
seewoo5 wants to merge 2 commits intomasterfrom
feature/radical-refactor

Conversation

@seewoo5
Copy link
Copy Markdown
Collaborator

@seewoo5 seewoo5 commented Dec 10, 2024


Seperated from #18882

Open in Gitpod

@seewoo5 seewoo5 self-assigned this Dec 10, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 10, 2024

PR summary ca91f5aa39

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ radical_mul_of_isUnit_left
+ radical_mul_of_isUnit_right
+ radical_of_isUnit
- radical_mul_unit
- radical_unit_eq_one
- radical_unit_mul

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Dec 10, 2024
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 11, 2024
@YaelDillies YaelDillies changed the title Minor refactoring of theorems on radical chore(Radical): minor refactoring of lemmas Dec 11, 2024
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 11, 2024

✌️ seewoo5 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Dec 11, 2024
@seewoo5
Copy link
Copy Markdown
Collaborator Author

seewoo5 commented Dec 11, 2024

bors r+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Radical): minor refactoring of lemmas [Merged by Bors] - chore(Radical): minor refactoring of lemmas Dec 11, 2024
@mathlib-bors mathlib-bors bot closed this Dec 11, 2024
@mathlib-bors mathlib-bors bot deleted the feature/radical-refactor branch December 11, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants