[Merged by Bors] - chore: split the nlinarith preprocessor for clarity#19841
Closed
eric-wieser wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore: split the nlinarith preprocessor for clarity#19841eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser wants to merge 2 commits intomasterfrom
Conversation
This makes it a little easier to trace the two halves separately, which is desirable since the second half has quadratic complexity.
PR summary 55a1b6f947Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
7fd4f6e to
48f8752
Compare
| linarithTraceProofs "so we added proofs" new_es | ||
| return new_es | ||
|
|
||
| /-- Get proofs for products of inequalities from `ls`. -/ |
Contributor
There was a problem hiding this comment.
Might it be worth adding a note here about the quadratic complexity here?
Contributor
|
bors d+ |
Contributor
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
This makes it a little easier to trace the two halves separately, which is desirable since the second half has quadratic complexity. The behavior and performance should be unchanged. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it a little easier to trace the two halves separately, which is desirable since the second half has quadratic complexity.
The behavior and performance should be unchanged.