Skip to content

[Merged by Bors] - chore: cleanup of manifold files#19807

Closed
sgouezel wants to merge 7 commits intomasterfrom
SG_prereq
Closed

[Merged by Bors] - chore: cleanup of manifold files#19807
sgouezel wants to merge 7 commits intomasterfrom
SG_prereq

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel commented Dec 8, 2024

As a preparation for #19696

Open in Gitpod

@sgouezel sgouezel added the t-differential-geometry Manifolds etc label Dec 8, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2024 •
edited
Loading

PR summary 6689d0411a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ StructureGroupoid.maximalAtlas_mono
+ contMDiffOn_zero_iff
+ contMDiff_zero_iff

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
222 -1 bare open (scoped) Classical

Current commit 6689d0411a
Reference commit 31530f31d5

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@sgouezel sgouezel mentioned this pull request Dec 8, 2024
Closed
2 tasks
grunweg
grunweg reviewed Dec 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extracting this. Two nits, optional.
maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 8, 2024
jcommelin
jcommelin reviewed Dec 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 9, 2024
@sgouezel
chore: cleanup of manifold files (#19807)
b670b3c 
As a preparation for #19696
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: cleanup of manifold files [Merged by Bors] - chore: cleanup of manifold files Dec 9, 2024
@mathlib-bors mathlib-bors bot closed this Dec 9, 2024
@mathlib-bors mathlib-bors bot deleted the SG_prereq branch December 9, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

@grunweg grunweg grunweg left review comments

Assignees

No one assigned

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sgouezel @jcommelin @grunweg