Skip to content

[Merged by Bors] - feat: separation of FiniteMeasure by StarSubalgebra#19782

Closed
JakobStiefel wants to merge 101 commits intomasterfrom
Stiefel_FiniteMeasureExt
Closed

[Merged by Bors] - feat: separation of FiniteMeasure by StarSubalgebra#19782
JakobStiefel wants to merge 101 commits intomasterfrom
Stiefel_FiniteMeasureExt

Conversation

@JakobStiefel
Copy link
Copy Markdown
Collaborator

@JakobStiefel JakobStiefel commented Dec 7, 2024

A StarSubalgebra of bounded continuous functions separates finite measures if it separates points. Important result in probability


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Dec 7, 2024
@JakobStiefel JakobStiefel added the t-measure-probability Measure theory / Probability theory label Dec 7, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2024

PR summary 210c7a1ce9

Import changes exceeding 2%

% File
+24.28% Mathlib.MeasureTheory.Measure.HasOuterApproxClosed

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.MeasureTheory.Measure.HasOuterApproxClosed 1602 1991 +389 (+24.28%)
Import changes for all files
Files Import difference
5 files Mathlib.Analysis.Normed.Group.ZeroAtInfty Mathlib.MeasureTheory.Integral.RieszMarkovKakutani.Basic Mathlib.Topology.ContinuousMap.Bounded.Star Mathlib.Topology.ContinuousMap.CompactlySupported Mathlib.Topology.ContinuousMap.ZeroAtInfty
1
Mathlib.MeasureTheory.Measure.HasOuterApproxClosed 389
Mathlib.Analysis.RCLike.BoundedContinuous (new file) 1561
Mathlib.MeasureTheory.Measure.FiniteMeasureExt (new file) 2212

Declarations diff

+ AlgHom.compLeftContinuousBounded
+ _root_.MonoidHom.compLeftContinuousBounded
+ _root_.RingHom.compLeftContinuousBounded
+ coe_toContinuousMapStarₐ
+ coe_toContinuousMapₐ
+ comp_apply
+ ext_of_forall_integral_eq_of_IsFiniteMeasure
+ ext_of_forall_mem_subalgebra_integral_eq_of_polish
+ ext_of_forall_mem_subalgebra_integral_eq_of_pseudoEMetric_complete_countable
+ instMulOneClass
+ lipschitzWith_ofReal
+ restrict_toContinuousMap_eq_toContinuousMapStar_restrict
+ toContinuousMapStarₐ
+ toContinuousMapₐ

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (1.00, 0.04)
Current number Change Type
25 1 large files

Current commit 210c7a1ce9
Reference commit 67019e0bbf

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@sgouezel sgouezel added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 8, 2024
@JakobStiefel JakobStiefel changed the title feat: separation of FiniteMeasaure by StarSubalgebra feat: separation of FiniteMeasure by StarSubalgebra Dec 9, 2024
JakobStiefel and others added 4 commits December 9, 2024 16:28
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@JakobStiefel JakobStiefel removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 4, 2025
Copy link
Copy Markdown
Contributor

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new approach looks nice!

@RemyDegenne RemyDegenne added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 5, 2025
@JakobStiefel JakobStiefel removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 17, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 19, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 19, 2025
@RemyDegenne
Copy link
Copy Markdown
Contributor

I merged master to fix the conflict introduced by the two PRs about to_additive that I opened to extract those changes from this PR.
However, the build fails because it can't find StarSubalgebra.restrictScalars for the statement of restrict_toContinuousMap_eq_toContinuousMapStar_restrict. It seems that StarSubalgebra.restrictScalars indeed does not exist and I am confused because I don't understand how this PR was successfully building before. Could you have a look? Sorry for the mess.

@RemyDegenne
Copy link
Copy Markdown
Contributor

I fixed it: some statement or file probably moved on master and was not imported anymore. I added an import and that fixed the issue.

Copy link
Copy Markdown
Contributor

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!
You can merge after resolving a few very minor things.
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 19, 2025

✌️ JakobStiefel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Mar 19, 2025
@JakobStiefel
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Mar 19, 2025
A `StarSubalgebra` of bounded continuous functions separates finite measures if it separates points. Important result in probability



Co-authored-by: Remy Degenne <remydegenne@gmail.com>
Co-authored-by: JakobStiefel <73285902+JakobStiefel@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 19, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: separation of FiniteMeasure by StarSubalgebra [Merged by Bors] - feat: separation of FiniteMeasure by StarSubalgebra Mar 19, 2025
@mathlib-bors mathlib-bors bot closed this Mar 19, 2025
@mathlib-bors mathlib-bors bot deleted the Stiefel_FiniteMeasureExt branch March 19, 2025 11:12
tukamilano pushed a commit that referenced this pull request Mar 20, 2025
A `StarSubalgebra` of bounded continuous functions separates finite measures if it separates points. Important result in probability



Co-authored-by: Remy Degenne <remydegenne@gmail.com>
Co-authored-by: JakobStiefel <73285902+JakobStiefel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). large-import Automatically added label for PRs with a significant increase in transitive imports new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-measure-probability Measure theory / Probability theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants