Skip to content

[Merged by Bors] - feat(List): count a (l₁.diff l₂) = count a l₁ - count a l₂#19778

Closed
YaelDillies wants to merge 2 commits intomasterfrom
list_count_diff
Closed

[Merged by Bors] - feat(List): count a (l₁.diff l₂) = count a l₁ - count a l₂#19778
YaelDillies wants to merge 2 commits intomasterfrom
list_count_diff

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented Dec 7, 2024 •
edited
Loading

This will help not importing algebra when defining multisets

Open in Gitpod

@YaelDillies
feat(List): count a (l₁.diff l₂) = count a l₁ - count a l₂
b8167fa 
This will help no importing algebra when defining multisets
@YaelDillies YaelDillies added the t-data Data (lists, quotients, numbers, etc) label Dec 7, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2024 •
edited
Loading

PR summary c6f422d60d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ countP_diff
+ countP_erase
+ count_diff
+ subperm_iff_count

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@YaelDillies YaelDillies mentioned this pull request Dec 7, 2024
Closed
3 tasks
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Dec 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 7, 2024
Vierkantor
Vierkantor approved these changes Dec 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 9, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Dec 9, 2024
@YaelDillies
Copy link
Copy Markdown
Contributor Author

YaelDillies commented Dec 9, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 9, 2024
@YaelDillies
feat(List): count a (l₁.diff l₂) = count a l₁ - count a l₂ (#19778)
dda658e 
This will help not importing algebra when defining multisets
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(List): count a (l₁.diff l₂) = count a l₁ - count a l₂ [Merged by Bors] - feat(List): count a (l₁.diff l₂) = count a l₁ - count a l₂ Dec 9, 2024
@mathlib-bors mathlib-bors bot closed this Dec 9, 2024
@mathlib-bors mathlib-bors bot deleted the list_count_diff branch December 9, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YaelDillies @Vierkantor @Ruben-VandeVelde