Skip to content

[Merged by Bors] - refactor: unbundle Multiset.card#19777

Closed
YaelDillies wants to merge 5 commits intomasterfrom
unbundle_multiset_card
Closed

[Merged by Bors] - refactor: unbundle Multiset.card#19777
YaelDillies wants to merge 5 commits intomasterfrom
unbundle_multiset_card

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented Dec 7, 2024

This is a first step towards not importing algebra to define multisets.

Open in Gitpod

@YaelDillies
refactor: unbundle Multiset.card
5f5d42b 
This is a first step towards not importing algebra to define multisets.
@YaelDillies YaelDillies added the t-data Data (lists, quotients, numbers, etc) label Dec 7, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2024 •
edited
Loading

PR summary 6ace55cf1f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Multiset.card_finsuppSum
+ cardHom
+ card_sum

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@YaelDillies YaelDillies mentioned this pull request Dec 7, 2024
Closed
3 tasks
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Dec 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly disappointing, but not as bad as I feared

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 7, 2024
Vierkantor
Vierkantor approved these changes Dec 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely lose some convenience later on if we have to unbundle this map. I suppose the alternative would be to avoid importing count in the files where we don't need it. But that would lead to this combinatorial explosion in dependencies if we want to talk about the count of erase etc.

In the end, the downstream impact is not too big so I think this is an okay way to do it.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 9, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Dec 9, 2024
@YaelDillies
Copy link
Copy Markdown
Contributor Author

YaelDillies commented Dec 9, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 9, 2024
@YaelDillies
refactor: unbundle Multiset.card (#19777)
888b1ef 
This is a first step towards not importing algebra to define multisets.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: unbundle Multiset.card [Merged by Bors] - refactor: unbundle Multiset.card Dec 9, 2024
@mathlib-bors mathlib-bors bot closed this Dec 9, 2024
@mathlib-bors mathlib-bors bot deleted the unbundle_multiset_card branch December 9, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YaelDillies @Vierkantor @Ruben-VandeVelde