perf: qqify two functions in linarith#19771
Draft
robertylewis wants to merge 5 commits intomasterfrom
Draft
Conversation
Member
robertylewis
commented
Dec 6, 2024
PR summary abb47c5b65Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 2d4175c. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 11, 2025
Inspired by hacking done with @robertylewis and @hrmacbeth which resulted in #19771. The effect is that the traces messages are now hierarchical; though it's easy not to notice in VSCode without a better version of leanprover/lean4#6345. See https://profiler.firefox.com/public/smkc5ffh9318w177gps2x9e5b6wy117s6f18e6g/flame-graph/?globalTrackOrder=0&thread=0&transforms=ff-2659&v=10 for an example output produced with ```bash lake lean MathlibTest/linarith.lean -- \ -Dtrace.profiler=true \ -Dtrace.profiler.threshold=1 \ -Dtrace.profiler.output.pp=true \ -Dtrace.profiler.output=linarith-profile.json ``` Some inconclusive discussion about best practices for `withTraceNode` is [on Zulip here](https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/Using.20withTraceNode/near/489198580). Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Contributor
|
Coming here for PR triage: what's the status of this PR? Should this be marked help-wanted or please-adopt? |
Collaborator
|
This pull request has conflicts, please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.