[Merged by Bors] - chore: cleanup set_option linter.deprecated#19701
Closed
[Merged by Bors] - chore: cleanup set_option linter.deprecated#19701
Conversation
PR summary 9f175f1354
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.BigOperators.Group.List | 386 | 388 | +2 (+0.52%) |
| Mathlib.SetTheory.Cardinal.Basic | 644 | 646 | +2 (+0.31%) |
| Mathlib.SetTheory.Ordinal.Arithmetic | 653 | 655 | +2 (+0.31%) |
| Mathlib.SetTheory.Ordinal.Rank | 654 | 656 | +2 (+0.31%) |
| Mathlib.Order.Extension.Well | 656 | 658 | +2 (+0.30%) |
| Mathlib.SetTheory.Ordinal.FixedPoint | 657 | 659 | +2 (+0.30%) |
| Mathlib.SetTheory.Cardinal.Aleph | 677 | 679 | +2 (+0.30%) |
| Mathlib.LinearAlgebra.Prod | 743 | 745 | +2 (+0.27%) |
| Mathlib.Topology.Order.Basic | 771 | 773 | +2 (+0.26%) |
| Mathlib.LinearAlgebra.CliffordAlgebra.Grading | 1405 | 1406 | +1 (+0.07%) |
| Mathlib.Analysis.Analytic.Composition | 1481 | 1482 | +1 (+0.07%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 3768 files with changed transitive imports taking up over 163177 characters: this is too many to display! | |
You can run scripts/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
Increase in tech debt: (relative, absolute) = (32.00, 0.37)
| Current number | Change | Type |
|---|---|---|
| 87 | 32 | disabled deprecation lints |
Current commit 9f175f1354
Reference commit 72b0941b7c
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Contributor
Author
|
There are some slight import increases because I moved some |
grunweg
reviewed
Dec 3, 2024
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
(I trust you that all set_option linter.deprecated in are actually required. I only checked some of them.)
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
Remove several uses of deprecated lemmas in non-deprecated lemmas. Also convert all `set_option linter.deprecated false` to `set_option linter.deprecated false in`, so it is easier for us to count via regex what remains. I think ``` set_option linter\.deprecated false.*(?:(?:\n/--.*?-/\n(?!.*deprecated))|\n(?!.*deprecated|/--)) ``` is the correct regex to use now: it accounts properly for intervening doc-strings. It now reports that there are only ~~three~~ one! file~~s~~ that use `set_option linter.deprecated false` on non-deprecated declarations, namely: * ~~Mathlib.Data.List.Permutation~~ (fixed by moving some List theorems earlier) * ~~Mathlib.LinearAlgebra.CliffordAlgebra.Grading~~ (replace `AlgHom.map_zero` with just `map_zero`; only costs 2000 heartbeats) * Mathlib.SetTheory.Ordinal.Arithmetic (which is a mess)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove several uses of deprecated lemmas in non-deprecated lemmas.
Also convert all
set_option linter.deprecated falsetoset_option linter.deprecated false in, so it is easier for us to count via regex what remains.I think
is the correct regex to use now: it accounts properly for intervening doc-strings. It now reports that there are only
threeone! filesthat useset_option linter.deprecated falseon non-deprecated declarations, namely:Mathlib.Data.List.Permutation(fixed by moving some List theorems earlier)Mathlib.LinearAlgebra.CliffordAlgebra.Grading(replaceAlgHom.map_zerowith justmap_zero; only costs 2000 heartbeats)