Skip to content

[Merged by Bors] - chore: turn erw into rw for free#19689

Closed
Vierkantor wants to merge 1 commit intomasterfrom
erw-to-rw-2024-12-02
Closed

[Merged by Bors] - chore: turn erw into rw for free#19689
Vierkantor wants to merge 1 commit intomasterfrom
erw-to-rw-2024-12-02

Conversation

@Vierkantor
Copy link
Copy Markdown
Contributor

The erw linter from #17638 caught these erws that can become rw without breaking the proofs.


Open in Gitpod

The `erw` linter from #17638 caught these `erw`s that can become `rw` without breaking the proofs.
@Vierkantor Vierkantor added easy < 20s of review time. See the lifecycle page for guidelines. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Dec 2, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 2, 2024

PR summary dc07b2b784

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (3.00, 0.00)
Current number Change Type
1522 -3 erw

Current commit dc07b2b784
Reference commit 5255add1b2

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 2, 2024
The `erw` linter from #17638 caught these `erw`s that can become `rw` without breaking the proofs.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: turn erw into rw for free [Merged by Bors] - chore: turn erw into rw for free Dec 2, 2024
@mathlib-bors mathlib-bors bot closed this Dec 2, 2024
@mathlib-bors mathlib-bors bot deleted the erw-to-rw-2024-12-02 branch December 2, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants