Skip to content

[Merged by Bors] - docs(RootSystem/Defs): add more details to the doc for root pairings.#19683

Closed
faenuccio wants to merge 2 commits intomasterfrom
fae_PR_docRootSystem
Closed

[Merged by Bors] - docs(RootSystem/Defs): add more details to the doc for root pairings.#19683
faenuccio wants to merge 2 commits intomasterfrom
fae_PR_docRootSystem

Conversation

@faenuccio
Copy link
Copy Markdown
Contributor

Add a comparison with the "classical" literature in the definition of a root pairing.


Open in Gitpod

@faenuccio faenuccio requested a review from ocfnash December 2, 2024 10:33
@faenuccio faenuccio added documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) labels Dec 2, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 2, 2024

PR summary a8b76a3111

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@faenuccio faenuccio removed the easy < 20s of review time. See the lifecycle page for guidelines. label Dec 2, 2024
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; always great to improve our docs

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 2, 2024
…s. (#19683)

Add a comparison with the "classical" literature in the definition of a root pairing.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title docs(RootSystem/Defs): add more details to the doc for root pairings. [Merged by Bors] - docs(RootSystem/Defs): add more details to the doc for root pairings. Dec 2, 2024
@mathlib-bors mathlib-bors bot closed this Dec 2, 2024
@mathlib-bors mathlib-bors bot deleted the fae_PR_docRootSystem branch December 2, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants