Skip to content

[Merged by Bors] - feat: unique differentiability of preimages under projection doesn't need the bundle to be smooth#19682

Closed
sgouezel wants to merge 5 commits intomasterfrom
SG_unique2
Closed

[Merged by Bors] - feat: unique differentiability of preimages under projection doesn't need the bundle to be smooth#19682
sgouezel wants to merge 5 commits intomasterfrom
SG_unique2

Conversation

@sgouezel
Copy link
Copy Markdown
Contributor

@sgouezel sgouezel commented Dec 2, 2024

Open in Gitpod

@sgouezel sgouezel added the t-differential-geometry Manifolds etc label Dec 2, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 2, 2024 •
edited
Loading

PR summary 881c77c45d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ UniqueMDiffOn.bundle_preimage
+ UniqueMDiffWithinAt.bundle_preimage
+ UniqueMDiffWithinAt.bundle_preimage'

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@sgouezel sgouezel mentioned this pull request Dec 2, 2024
Closed
2 tasks
ocfnash
ocfnash approved these changes Dec 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 4, 2024

✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Dec 4, 2024
sgouezel and others added 2 commits December 4, 2024 16:35
@sgouezel @ocfnash
Update Mathlib/Topology/PartialHomeomorph.lean
30be988 
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
@sgouezel
fix
881c77c
@sgouezel
Copy link
Copy Markdown
Contributor Author

sgouezel commented Dec 4, 2024

bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 4, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 4, 2024
@sgouezel
feat: unique differentiability of preimages under projection doesn't …
41cbc10 
…need the bundle to be smooth (#19682)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: unique differentiability of preimages under projection doesn't need the bundle to be smooth [Merged by Bors] - feat: unique differentiability of preimages under projection doesn't need the bundle to be smooth Dec 4, 2024
@mathlib-bors mathlib-bors bot closed this Dec 4, 2024
@mathlib-bors mathlib-bors bot deleted the SG_unique2 branch December 4, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocfnash ocfnash ocfnash approved these changes

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sgouezel @ocfnash