[Merged by Bors] - chore: remove PartENat from PowerSeries#19622
Closed
[Merged by Bors] - chore: remove PartENat from PowerSeries#19622
Conversation
PR summary 8f51556d4f
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.PowerSeries.Order | 1045 | 1043 | -2 (-0.19%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.PowerSeries.Order |
-2 |
Declarations diff
+ add_lt_top
+ coe_inj
+ coe_le_coe
+ coe_lift
+ coe_lt_coe
+ forall_coeff_eq_zero
+ le_lift_iff
+ lift
+ lift_add
+ lift_coe
+ lift_le_iff
+ lift_lt_iff
+ lift_ofNat
+ lift_one
+ lift_zero
+ lt_lift_iff
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
eric-wieser
reviewed
Dec 1, 2024
Comment on lines
+53
to
56
| def order (φ : R⟦X⟧) : ℕ∞ := | ||
| letI := Classical.decEq R | ||
| letI := Classical.decEq R⟦X⟧ | ||
| if h : φ = 0 then ⊤ else Nat.find (exists_coeff_ne_zero_iff_ne_zero.mpr h) |
Member
There was a problem hiding this comment.
This one is quite strange; the whole point of PartENat is to make this type of thing computable, but then the implementation was noncomputable anyway!
1 task
Contributor
|
bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
- [x] depends on: #19622 (perhaps unnecessarily)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.