Skip to content

[Merged by Bors] - feat(Finset): (s ∪ t).Nonempty ↔ s.Nonempty ∨ t.Nonempty#19609

Closed
YaelDillies wants to merge 1 commit intomasterfrom
union_nonempty
Closed

[Merged by Bors] - feat(Finset): (s ∪ t).Nonempty ↔ s.Nonempty ∨ t.Nonempty#19609
YaelDillies wants to merge 1 commit intomasterfrom
union_nonempty

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

From GrowthInGroups (LeanCamCombi)


Open in Gitpod

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Nov 29, 2024
@github-actions
Copy link
Copy Markdown

PR summary 9185544e95

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ union_nonempty

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 1, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 1, 2024
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 2, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Finset): (s ∪ t).Nonempty ↔ s.Nonempty ∨ t.Nonempty [Merged by Bors] - feat(Finset): (s ∪ t).Nonempty ↔ s.Nonempty ∨ t.Nonempty Dec 2, 2024
@mathlib-bors mathlib-bors bot closed this Dec 2, 2024
@mathlib-bors mathlib-bors bot deleted the union_nonempty branch December 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants