Skip to content

[Merged by Bors] - chore: NoZeroSMulDivisors instances for (Add)MonoidAlgebra/Polynomial#19592

Closed
alreadydone wants to merge 4 commits intomasterfrom
NoZeroSMulDivisors_polynomial
Closed

[Merged by Bors] - chore: NoZeroSMulDivisors instances for (Add)MonoidAlgebra/Polynomial#19592
alreadydone wants to merge 4 commits intomasterfrom
NoZeroSMulDivisors_polynomial

Conversation

@alreadydone
Copy link
Copy Markdown
Contributor

Also generalizes the instance for Finsupp.


Open in Gitpod

@alreadydone alreadydone added easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) labels Nov 29, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 29, 2024

PR summary b85e489406

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance {S : Type*} [Zero S] [SMulZeroClass S R] [NoZeroSMulDivisors S R] :
-+++ noZeroSMulDivisors

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 3, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 3, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: NoZeroSMulDivisors instances for (Add)MonoidAlgebra/Polynomial [Merged by Bors] - chore: NoZeroSMulDivisors instances for (Add)MonoidAlgebra/Polynomial Dec 3, 2024
@mathlib-bors mathlib-bors bot closed this Dec 3, 2024
@mathlib-bors mathlib-bors bot deleted the NoZeroSMulDivisors_polynomial branch December 3, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants