Skip to content

[Merged by Bors] - feat(Pointwise): closure (s ^ n) = closure s if 1 ∈ s#19577

Closed
YaelDillies wants to merge 1 commit intomasterfrom
closure_pow
Closed

[Merged by Bors] - feat(Pointwise): closure (s ^ n) = closure s if 1 ∈ s#19577
YaelDillies wants to merge 1 commit intomasterfrom
closure_pow

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented Nov 28, 2024

@YaelDillies YaelDillies added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-algebra Algebra (groups, rings, fields, etc) labels Nov 28, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 28, 2024

PR summary 9ff7492616

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

++ closure_pow
++ closure_pow_le

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-bors mathlib-bors bot deleted the branch master November 28, 2024 20:24
@mathlib-bors mathlib-bors bot closed this Nov 28, 2024
@YaelDillies YaelDillies reopened this Nov 28, 2024
@YaelDillies YaelDillies changed the base branch from gcongr_closure_mono to master November 28, 2024 20:28
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 28, 2024
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Too bad about the duplication

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 2, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 2, 2024
@YaelDillies
Copy link
Copy Markdown
Contributor Author

Yeah, I doubt there is any reasonable way to unify both proofs

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 3, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 3, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Pointwise): closure (s ^ n) = closure s if 1 ∈ s [Merged by Bors] - feat(Pointwise): closure (s ^ n) = closure s if 1 ∈ s Dec 3, 2024
@mathlib-bors mathlib-bors bot closed this Dec 3, 2024
@mathlib-bors mathlib-bors bot deleted the closure_pow branch December 3, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants