Skip to content

[Merged by Bors] - feat(Algebra/Homology): more duality results#19559

Closed
joelriou wants to merge 3 commits intomasterfrom
homology-more-duality
Closed

[Merged by Bors] - feat(Algebra/Homology): more duality results#19559
joelriou wants to merge 3 commits intomasterfrom
homology-more-duality

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Nov 28, 2024 •
edited
Loading

Given an homological complex K, we introduce duality isomorphisms like cyclesOpIso : K.op.cycles i ≅ op (K.opcycles i) and study their naturality.

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Nov 28, 2024
@joelriou joelriou mentioned this pull request Nov 28, 2024
Closed
4 tasks
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 28, 2024 •
edited
Loading

PR summary 80c9c1b838

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ cyclesOpIso
+ cyclesOpIso_inv_op_iCycles
+ cyclesOpNatIso
+ fromOpcycles_eq_zero
+ homologyOpIso_hom_naturality
+ homologyOpIso_inv_naturality
+ homologyOpNatIso
+ homologyOp_hom_naturality
+ instance (K : HomologicalComplex V c) (i : ι) [K.HasHomology i] :
+ instance (K : HomologicalComplex Vᵒᵖ c) (i : ι) [K.HasHomology i] :
+ op_pOpcycles_opcyclesOpIso_hom
+ opcyclesOpIso
+ opcyclesOpNatIso
+ toCycles_eq_zero
++ cyclesOpIso_hom_naturality
++ cyclesOpIso_inv_naturality
++ fromOpcycles_op_cyclesOpIso_inv
++ opcyclesOpIso_hom_naturality
++ opcyclesOpIso_hom_toCycles_op
++ opcyclesOpIso_inv_naturality

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@dagurtomas
Copy link
Copy Markdown
Contributor

dagurtomas commented Nov 29, 2024 •
edited
Loading

Does it not make sense to promote these isomorphisms to natural isomorphisms of functors (I guess something like cyclesFunctor.op ≅ opFunctor ⋙ opcyclesFunctor, for example?), given that you already prove naturality?

@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 29, 2024
@joelriou
Copy link
Copy Markdown
Contributor Author

joelriou commented Nov 29, 2024

Thanks for the suggestions. I have added natural iso versions.

@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 29, 2024
@dagurtomas
Copy link
Copy Markdown
Contributor

dagurtomas commented Nov 29, 2024

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 29, 2024

🚀 Pull request has been placed on the maintainer queue by dagurtomas.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 29, 2024
jcommelin
jcommelin reviewed Nov 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 29, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 30, 2024
@joelriou
feat(Algebra/Homology): more duality results (#19559)
e1064d2 
Given an homological complex `K`, we introduce duality isomorphisms like `cyclesOpIso : K.op.cycles i ≅ op (K.opcycles i)` and study their naturality.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Homology): more duality results [Merged by Bors] - feat(Algebra/Homology): more duality results Nov 30, 2024
@mathlib-bors mathlib-bors bot closed this Nov 30, 2024
@mathlib-bors mathlib-bors bot deleted the homology-more-duality branch November 30, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees

No one assigned

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joelriou @dagurtomas @jcommelin