[Merged by Bors] - chore(Pointwise): move auxiliary lemma out#19537
Closed
YaelDillies wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore(Pointwise): move auxiliary lemma out#19537YaelDillies wants to merge 3 commits intomasterfrom
YaelDillies wants to merge 3 commits intomasterfrom
Conversation
This has nothing to do with pointwise actions and doesn't need to be additivised
PR summary d4dfd042a1
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Order.Monotone.Basic | 170 | 171 | +1 (+0.59%) |
Import changes for all files
| Files | Import difference |
|---|---|
34 filesMathlib.GroupTheory.OreLocalization.OreSet Mathlib.Order.Filter.Defs Mathlib.Order.Circular Mathlib.GroupTheory.Subsemigroup.Center Mathlib.Data.Prod.Lex Mathlib.Algebra.Order.Monoid.Unbundled.OrderDual Mathlib.Algebra.Ring.Centralizer Mathlib.Data.Sigma.Order Mathlib.Order.MinMax Mathlib.Order.BoundedOrder.Lattice Mathlib.Data.Set.Subsingleton Mathlib.Algebra.Group.Center Mathlib.Order.PropInstances Mathlib.Data.List.SplitLengths Mathlib.Algebra.Group.Subsemigroup.Defs Mathlib.Data.Bundle Mathlib.Order.Monotone.Basic Mathlib.Order.Monotone.Monovary Mathlib.Order.BoundedOrder.Monotone Mathlib.Data.Part Mathlib.Order.Heyting.Basic Mathlib.Data.PSigma.Order Mathlib.Data.Nat.Order.Lemmas Mathlib.Data.SetLike.Basic Mathlib.Order.Iterate Mathlib.Algebra.Group.Submonoid.Defs Mathlib.Logic.Function.FiberPartition Mathlib.Data.Set.BoolIndicator Mathlib.Deprecated.MinMax Mathlib.Order.BooleanAlgebra Mathlib.Algebra.Order.Monoid.Unbundled.Defs Mathlib.Order.Lattice Mathlib.Data.Set.Basic Mathlib.Order.Disjoint |
1 |
Declarations diff
+ Group.card_nsmul_eq_card_nsmulpow_card_univ_aux
+ Group.card_pow_eq_card_pow_card_univ_aux
+ Nat.stabilises_of_monotone
- card_pow_eq_card_pow_card_univ_aux
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
1 task
b-mehta
reviewed
Nov 27, 2024
| alias Group.card_pow_eq_card_pow_card_univ_aux := Nat.stabilises_of_monotone | ||
|
|
||
| @[deprecated (since := "2024-11-27")] | ||
| alias Group.card_nsmul_eq_card_nsmulpow_card_univ_aux := Nat.stabilises_of_monotone |
Contributor
There was a problem hiding this comment.
Seems like we should try to automatically detect if to_additive didn't modify the statement
Contributor
Author
There was a problem hiding this comment.
I am not convinced yet that there isn't a legitimate use for it, but yes good idea
Contributor
|
bors d+ |
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
|
As this PR is labelled bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
This has nothing to do with pointwise actions and doesn't need to be additivised
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has nothing to do with pointwise actions and doesn't need to be additivised