Skip to content

[Merged by Bors] - chore: adaptation to batteries#1055#19487

Closed
fgdorais wants to merge 10 commits intomasterfrom
batteries-pr-testing-1055
Closed

[Merged by Bors] - chore: adaptation to batteries#1055#19487
fgdorais wants to merge 10 commits intomasterfrom
batteries-pr-testing-1055

Conversation

@fgdorais
Copy link
Copy Markdown
Collaborator

@fgdorais fgdorais commented Nov 25, 2024


Once batteries#1055 is merged:

  • Edit lakefile to point to batteries/main
  • Run lake update batteries
  • Commit and merge

Open in Gitpod

@fgdorais fgdorais added the blocked-by-batt-PR This PR depends on a PR to Batteries label Nov 25, 2024
@fgdorais fgdorais changed the title Batteries pr testing 1055 chore: adaptation to batteries#1055 Nov 25, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 25, 2024

PR summary 380346231b

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.Fin.VecNotation 339 335 -4 (-1.18%)
Mathlib.Data.List.FinRange 351 352 +1 (+0.28%)
Mathlib.ModelTheory.Encoding 789 790 +1 (+0.13%)
Import changes for all files
Files Import difference
There are 3663 files with changed transitive imports taking up over 158949 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

- finRange
- finRange_succ
- finRange_zero
- getElem_finRange
- length_finRange

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 26, 2024
@kim-em kim-em removed blocked-by-batt-PR This PR depends on a PR to Batteries merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Nov 26, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 26, 2024

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 26, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 26, 2024

Build failed (retrying...):

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 26, 2024

Canceled.

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 26, 2024

This will hold up nightly-testing, so:

bors p=10

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 26, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 26, 2024

Build failed:

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 26, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 26, 2024

Build failed:

@mattrobball
Copy link
Copy Markdown
Contributor

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 26, 2024

Build failed:

@mattrobball
Copy link
Copy Markdown
Contributor

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
Co-authored-by: Matthew Ballard <matt@mrb.email>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 26, 2024

Build failed:

@mattrobball
Copy link
Copy Markdown
Contributor

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
Co-authored-by: Matthew Ballard <matt@mrb.email>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 26, 2024

Build failed:

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 26, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
Co-authored-by: Matthew Ballard <matt@mrb.email>
mathlib-bors bot pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: F. G. Dorais <fgdorais@gmail.com>
Co-authored-by: Kim Morrison <kim@tqft.net>
Co-authored-by: Matthew Ballard <matt@mrb.email>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: adaptation to batteries#1055 [Merged by Bors] - chore: adaptation to batteries#1055 Nov 26, 2024
@mathlib-bors mathlib-bors bot closed this Nov 26, 2024
@mathlib-bors mathlib-bors bot deleted the batteries-pr-testing-1055 branch November 26, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants