Skip to content

[Merged by Bors] - fix: escape line breaks in create adaptation PR#19451

Closed
adomani wants to merge 1 commit intomasterfrom
adomani/try_to_fix_formattingin_create_adaptation
Closed

[Merged by Bors] - fix: escape line breaks in create adaptation PR#19451
adomani wants to merge 1 commit intomasterfrom
adomani/try_to_fix_formattingin_create_adaptation

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Nov 25, 2024


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary 30fb1a548f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 25, 2024
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Nov 25, 2024

In case someone looks at this and wonders about the failed CI action: this is expected and is what this PR should fix. The current bors-related actions on master do not checkout the script that they also use, hence the failure.

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: escape line breaks in create adaptation PR [Merged by Bors] - fix: escape line breaks in create adaptation PR Nov 25, 2024
@mathlib-bors mathlib-bors bot closed this Nov 25, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/try_to_fix_formattingin_create_adaptation branch November 25, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants