Skip to content

[Merged by Bors] - chore(Multilinear/Basic): address a porting note#19443

Closed
urkud wants to merge 1 commit intomasterfrom
YK-port-note
Closed

[Merged by Bors] - chore(Multilinear/Basic): address a porting note#19443
urkud wants to merge 1 commit intomasterfrom
YK-port-note

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Nov 24, 2024


Open in Gitpod

@urkud urkud added easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc) labels Nov 24, 2024
@github-actions
Copy link
Copy Markdown

PR summary e31ab85dbc

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
5083 -1 porting notes

Current commit e31ab85dbc
Reference commit 5483f1cf4b

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 24, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 25, 2024

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 25, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Multilinear/Basic): address a porting note [Merged by Bors] - chore(Multilinear/Basic): address a porting note Nov 25, 2024
@mathlib-bors mathlib-bors bot closed this Nov 25, 2024
@mathlib-bors mathlib-bors bot deleted the YK-port-note branch November 25, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants