Skip to content

[Merged by Bors] - chore: remove unused Category assumption#19416

Closed
adomani wants to merge 4 commits intomasterfrom
adomani/weird_discrete_category
Closed

[Merged by Bors] - chore: remove unused Category assumption#19416
adomani wants to merge 4 commits intomasterfrom
adomani/weird_discrete_category

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Nov 23, 2024

The Category assumption is unused, as Discrete subsumes it.


Open in Gitpod

@adomani adomani requested a review from dagurtomas November 23, 2024 18:47
@github-actions github-actions bot added the t-category-theory Category theory label Nov 23, 2024
@github-actions
Copy link
Copy Markdown

PR summary 35887f437b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou
Copy link
Copy Markdown
Contributor

Indeed, we should remove the assumption [Category C]. Could you update the description of the PR?

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2024

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 23, 2024
@adomani adomani changed the title bug: Category is unused chore: remove unused Category assumption Nov 23, 2024
@adomani adomani removed the request for review from dagurtomas November 23, 2024 19:35
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Nov 23, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Nov 23, 2024
The `Category` assumption is unused, as `Discrete` subsumes it.
@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 23, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove unused Category assumption [Merged by Bors] - chore: remove unused Category assumption Nov 23, 2024
@mathlib-bors mathlib-bors bot closed this Nov 23, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/weird_discrete_category branch November 23, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants