Skip to content

[Merged by Bors] - chore(discover-lean-pr-testing): ignore stage0 PRs, more tracing#19405

Closed
jcommelin wants to merge 3 commits intomasterfrom
jmc-disco-lean-test-prs-4
Closed

[Merged by Bors] - chore(discover-lean-pr-testing): ignore stage0 PRs, more tracing#19405
jcommelin wants to merge 3 commits intomasterfrom
jmc-disco-lean-test-prs-4

Conversation

@jcommelin
Copy link
Copy Markdown
Member


Open in Gitpod

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Nov 23, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 23, 2024

PR summary 68a9ddc2f5

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@adomani
Copy link
Copy Markdown
Contributor

adomani commented Nov 23, 2024

I missed this earlier, I think that if you replace

 RELEVANT_BRANCHES="$RELEVANT_BRANCHES\n- $BRANCH"

with

 RELEVANT_BRANCHES="$RELEVANT_BRANCHES"$'\n- '"$BRANCH"

may increase the chances of getting the formatting right.

@adomani
Copy link
Copy Markdown
Contributor

adomani commented Nov 23, 2024

Let's see how it works!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2024

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 23, 2024
@adomani
Copy link
Copy Markdown
Contributor

adomani commented Nov 25, 2024

Thanks: let's get the CI AI to tell us about bugs in this version!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 25, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(discover-lean-pr-testing): ignore stage0 PRs, more tracing [Merged by Bors] - chore(discover-lean-pr-testing): ignore stage0 PRs, more tracing Nov 25, 2024
@mathlib-bors mathlib-bors bot closed this Nov 25, 2024
@mathlib-bors mathlib-bors bot deleted the jmc-disco-lean-test-prs-4 branch November 25, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants