Skip to content

[Merged by Bors] - chore: more simpNF cleanup#19395

Closed
kim-em wants to merge 3 commits intomasterfrom
more_simpNF
Closed

[Merged by Bors] - chore: more simpNF cleanup#19395
kim-em wants to merge 3 commits intomasterfrom
more_simpNF

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Nov 23, 2024

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 23, 2024

PR summary 5f7bf84551

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ is_invariant_one'
+ not_isUnit_iff
- curryFinFinset_apply_const_aux
- curryFinFinset_symm_apply_piecewise_const_aux

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (14.43, 0.07)
Current number Change Type
5060 -25 porting notes
207 -14 disabled simpNF lints

Current commit 5f7bf84551
Reference commit 43c93172bd

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).


-- `simpNF` times out, but only in CI where all of `Mathlib` is imported
attribute [nolint simpNF] lcRow0Extend_apply lcRow0Extend_symm_apply
-- attribute [nolint simpNF] lcRow0Extend_apply lcRow0Extend_symm_apply
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still checking in CI.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like CI liked the change!

@kim-em kim-em added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Nov 23, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Nov 23, 2024
Copy link
Copy Markdown
Contributor

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks: this looks good to me!

bors d+


-- `simpNF` times out, but only in CI where all of `Mathlib` is imported
attribute [nolint simpNF] lcRow0Extend_apply lcRow0Extend_symm_apply
-- attribute [nolint simpNF] lcRow0Extend_apply lcRow0Extend_symm_apply
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like CI liked the change!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2024

✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 23, 2024
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Nov 23, 2024

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 23, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: more simpNF cleanup [Merged by Bors] - chore: more simpNF cleanup Nov 23, 2024
@mathlib-bors mathlib-bors bot closed this Nov 23, 2024
@mathlib-bors mathlib-bors bot deleted the more_simpNF branch November 23, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants