[Merged by Bors] - feat: introduce the missing notation for AddHom#19387
Closed
PieterCuijpers wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - feat: introduce the missing notation for AddHom#19387PieterCuijpers wants to merge 3 commits intomasterfrom
AddHom#19387PieterCuijpers wants to merge 3 commits intomasterfrom
Conversation
PR summary 88db594244Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
AddHom
YaelDillies
approved these changes
Nov 23, 2024
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks! In the future, please follow our commit convention so that I don't have to fix your PR title 😉
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
kbuzzard
reviewed
Nov 23, 2024
Member
|
Thanks a lot! bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
AddHomAddHom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that there is notation for a non-unital monoid hom but not for a non-unital additive monoid hom,
and since I'm working on extensions of non-unital homomorphisms in my PR's on quantale, I found it natural to add this.