[Merged by Bors] - chore: split notation typeclasses out of Algebra.Group.Defs#19350
Closed
[Merged by Bors] - chore: split notation typeclasses out of Algebra.Group.Defs#19350
Conversation
Contributor
Author
|
This will presumably need a |
PR summary 728934fcd5
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.Part | 204 | 203 | -1 (-0.49%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 4466 files with changed transitive imports taking up over 188484 characters: this is too many to display! | |
You can run scripts/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Ruben-VandeVelde
approved these changes
Nov 22, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
The shake is a bit disappointing, but fine with me if you want to go ahead with this
Contributor
Author
|
Yes, no import impact at all, but I think it still makes sense to separate out notation typeclasses just as an organizational matter. Also, this file is always time-consuming when doing test case reduction, so I would like to think about it more in subsequent PRs. |
Member
|
Thanks 🎉 bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.