Skip to content

[Merged by Bors] - feat(CategoryTheory/Over): more API for post#19312

Closed
chrisflav wants to merge 3 commits intomasterfrom
chrisflav-affine-cat.3
Closed

[Merged by Bors] - feat(CategoryTheory/Over): more API for post#19312
chrisflav wants to merge 3 commits intomasterfrom
chrisflav-affine-cat.3

Conversation

@chrisflav
Copy link
Copy Markdown
Member


Open in Gitpod

@chrisflav chrisflav added the t-category-theory Category theory label Nov 20, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 20, 2024

PR summary 71db6a18ab

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Over.opEquivOpUnder
+ Over.opToOpUnder
+ Over.opToUnderOp
+ Under.opEquivOpOver
+ Under.opToOpOver
+ Under.opToOverOp
+ instance [F.Faithful] : (Over.post (X := X) F).Faithful
+ instance [F.Faithful] : (Under.post (X := X) F).Faithful
+ instance [F.Faithful] [F.Full] : (Over.post (X := X) F).Full
+ instance [F.Faithful] [F.Full] : (Under.post (X := X) F).Full
+ instance [F.Full] [F.EssSurj] : (Over.post (X := X) F).EssSurj
+ instance [F.Full] [F.EssSurj] : (Under.post (X := X) F).EssSurj
+ instance [F.IsEquivalence] : (Over.post (X := X) F).IsEquivalence
+ instance [F.IsEquivalence] : (Under.post (X := X) F).IsEquivalence
++ mapCongr
++ mapIso
++ mapIso_functor
++ mapIso_inverse
++ postComp
++ postCongr
++ postEquiv
++ postMap
++ post_comp

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 21, 2024
@chrisflav chrisflav removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 22, 2024
@chrisflav
Copy link
Copy Markdown
Member Author

Thanks for the suggestions!

Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 24, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 24, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/Over): more API for post [Merged by Bors] - feat(CategoryTheory/Over): more API for post Nov 24, 2024
@mathlib-bors mathlib-bors bot closed this Nov 24, 2024
@mathlib-bors mathlib-bors bot deleted the chrisflav-affine-cat.3 branch November 24, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants