[Merged by Bors] - feat(to_additive): option to not translate operations on a type#19297
Closed
fpvandoorn wants to merge 11 commits intomasterfrom
Closed
[Merged by Bors] - feat(to_additive): option to not translate operations on a type#19297fpvandoorn wants to merge 11 commits intomasterfrom
fpvandoorn wants to merge 11 commits intomasterfrom
Conversation
This reverts commit 272c395535a706953d9f7f032d5619e3aade5c19.
20 tasks
PR summary 09fccabb48Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 61 | -1 | large files |
Current commit 09fccabb48
Reference commit 92f63d5c19
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
YaelDillies
reviewed
Nov 25, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
1 task
kmill
reviewed
Dec 22, 2024
|
|
||
| end | ||
|
|
||
| /-- |
Contributor
There was a problem hiding this comment.
I see you deleted a number of comments, like this one. Is all the information still documented somewhere?
So long as we're not losing documentation (or if what you do delete you think is not relevant anymore), then the PR looks good to me.
bors d+
Contributor
|
✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
The module doc was duplicating the tactic doc (see commit message) bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 22, 2024
* Also some cleanup in the `ToAdditive/Frontend` file (please review the first 3 commits separately), only the second commit actually changes the functionality of `to_additive`. The main cleanups: move doc-strings to the syntax declarations, remove the module doc which was just duplicating the `to_additive`-doc, and let a few internal functions depend on `Environment` instead of multiple other arguments. * In #19687 this is done for `Monoid.End` (in a separate PR, since that requires some library fixes).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToAdditive/Frontendfile (please review the first 3 commits separately), only the second commit actually changes the functionality ofto_additive. The main cleanups: move doc-strings to the syntax declarations, remove the module doc which was just duplicating theto_additive-doc, and let a few internal functions depend onEnvironmentinstead of multiple other arguments.Monoid.End(in a separate PR, since that requires some library fixes).