Skip to content

[Merged by Bors] - feat: more bound lemmas#19285

Closed
YaelDillies wants to merge 1 commit intomasterfrom
bound_one_lt_mul
Closed

[Merged by Bors] - feat: more bound lemmas#19285
YaelDillies wants to merge 1 commit intomasterfrom
bound_one_lt_mul

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

From LeanAPAP


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary e0d847a212

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Bound.one_lt_mul
+ ⟨_,

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Nov 20, 2024
@jcommelin
Copy link
Copy Markdown
Member

bors d=girving

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2024

✌️ girving can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 23, 2024
@girving
Copy link
Copy Markdown
Collaborator

girving commented Nov 23, 2024

These are great, thank you! one_lt_mul is exactly the right kind of use case for a branching bound lemma.

@girving
Copy link
Copy Markdown
Collaborator

girving commented Nov 23, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Nov 23, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: more bound lemmas [Merged by Bors] - feat: more bound lemmas Nov 24, 2024
@mathlib-bors mathlib-bors bot closed this Nov 24, 2024
@mathlib-bors mathlib-bors bot deleted the bound_one_lt_mul branch November 24, 2024 00:04
@YaelDillies
Copy link
Copy Markdown
Contributor Author

one_lt_mul is exactly the right kind of use case for a branching bound lemma.

Amazing! I wasn't sure I had understood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants