[Merged by Bors] - feat: isCoprime_mul_units_left, isCoprime_mul_units_right#19133
Closed
[Merged by Bors] - feat: isCoprime_mul_units_left, isCoprime_mul_units_right#19133
isCoprime_mul_units_left, isCoprime_mul_units_right#19133Conversation
PR summary 57594724f1Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Collaborator
Author
|
There are two things that I can do further (but not sure if it worths to do):
|
7 tasks
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
I probably would suggest reproving isCoprime_mul_unit_left/right, yes
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
tb65536
reviewed
Nov 28, 2024
Comment on lines
+279
to
+285
| theorem isCoprime_mul_unit_left (hu : IsUnit x) (y z : R) : | ||
| IsCoprime (x * y) (x * z) ↔ IsCoprime y z := | ||
| isCoprime_mul_units_left hu hu _ _ | ||
|
|
||
| theorem isCoprime_mul_unit_right (hu : IsUnit x) (y z : R) : | ||
| IsCoprime (y * x) (z * x) ↔ IsCoprime y z := | ||
| (isCoprime_mul_unit_right_left hu y (z * x)).trans (isCoprime_mul_unit_right_right hu y z) | ||
| isCoprime_mul_units_right hu hu _ _ |
Contributor
There was a problem hiding this comment.
Would it be better to remove these two lemmas and add deprecated aliases pointing to your lemmas?
Contributor
There was a problem hiding this comment.
No, I don't think so
Ruben-VandeVelde
approved these changes
Dec 2, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Thanks!
maintainer merge
Comment on lines
+279
to
+285
| theorem isCoprime_mul_unit_left (hu : IsUnit x) (y z : R) : | ||
| IsCoprime (x * y) (x * z) ↔ IsCoprime y z := | ||
| isCoprime_mul_units_left hu hu _ _ | ||
|
|
||
| theorem isCoprime_mul_unit_right (hu : IsUnit x) (y z : R) : | ||
| IsCoprime (y * x) (z * x) ↔ IsCoprime y z := | ||
| (isCoprime_mul_unit_right_left hu y (z * x)).trans (isCoprime_mul_unit_right_right hu y z) | ||
| isCoprime_mul_units_right hu hu _ _ |
Contributor
There was a problem hiding this comment.
No, I don't think so
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
Co-authored-by: Seewoo Lee <49933279+seewoo5@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
isCoprime_mul_units_left, isCoprime_mul_units_rightisCoprime_mul_units_left, isCoprime_mul_units_right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
isCoprime_mul_units_leftandisCoprime_mul_units_right. These are slight generalizations of same unit versionisCoprime_mul_unit_leftandisCoprime_mul_unit_right. Currently exists as a lemma in #18882.