Skip to content

[Merged by Bors] - chore(AlgebraicGeometry) add Scheme.Hom.appTop#19130

Closed
erdOne wants to merge 6 commits intomasterfrom
erd1/appTop
Closed

[Merged by Bors] - chore(AlgebraicGeometry) add Scheme.Hom.appTop#19130
erdOne wants to merge 6 commits intomasterfrom
erd1/appTop

Conversation

@erdOne
Copy link
Copy Markdown
Member

@erdOne erdOne commented Nov 16, 2024

to hide the defeq abuse f ⁻¹ᵁ ⊤ = ⊤


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 16, 2024

PR summary 2c4ed98e52

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsStableUnderBaseChange.pullback_fst_appTop
+ Scheme.homOfLE_appTop
+ Scheme.toSpecΓ_appTop
+ SpecIso_hom_appTop
+ SpecIso_inv_appTop_coord
+ comp_appTop
+ fromSpecStalk_appTop
+ homOfVector_appTop_coord
+ id_appTop
+ instance : HasAffineProperty (isomorphisms Scheme) fun X _ f _ ↦ IsAffine X ∧ IsIso (f.appTop) := by
+ instance : HasAffineProperty @IsFinite (fun X _ f _ ↦ IsAffine X ∧ RingHom.Finite (f.appTop)) := by
+ inv_appTop
+ isoOfIsAffine_hom_appTop
+ isoOfIsAffine_inv_appTop_coord
+ isoSpec_hom_appTop
+ isoSpec_inv_appTop
+ map_appTop_coord
+ morphismRestrict_appTop
+ preimage_basicOpen_top
+ reindex_appTop_coord
+ ι_appTop
++ appTop
- SpecIso_hom_app_top
- SpecIso_inv_app_top_coord
- homOfVector_app_top_coord
- instance : HasAffineProperty (isomorphisms Scheme) fun X _ f _ ↦ IsAffine X ∧ IsIso (f.app ⊤) := by
- instance : HasAffineProperty @IsFinite (fun X _ f _ ↦ IsAffine X ∧ RingHom.Finite (f.app ⊤)) := by
- isoOfIsAffine_hom_app_top
- isoOfIsAffine_inv_app_top_coord
- map_app_top_coord
- reindex_app_top_coord

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (3.00, 0.00)
Current number Change Type
1558 -3 erw

Current commit 2c4ed98e52
Reference commit b5155f3e85

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebraic-geometry Algebraic geometry label Nov 16, 2024
@erdOne
Copy link
Copy Markdown
Member Author

erdOne commented Nov 16, 2024

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 74b8374.
The entire run failed.
Found no significant differences.

@erdOne
Copy link
Copy Markdown
Member Author

erdOne commented Nov 16, 2024

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 8d7e419.
There were significant changes against commit aa5b6a4:

  Benchmark                                 Metric         Change
  ===============================================================
+ ~Mathlib.AlgebraicGeometry.AffineScheme   instructions    -5.9%
+ ~Mathlib.AlgebraicGeometry.AffineSpace    instructions   -57.5%

@github-actions
Copy link
Copy Markdown

File Instructions %
build -363.841⬝10⁹ (-0.22%)
lint -2.535⬝10⁹ (-0.03%)
Mathlib.AlgebraicGeometry.Restrict +2.54⬝10⁹ (+1.68%)
3 files, Instructions -2.0⬝10⁹
File Instructions %
Mathlib.AlgebraicGeometry.Scheme -1.265⬝10⁹ (-1.07%)
Mathlib.AlgebraicGeometry.Morphisms.AffineAnd -1.274⬝10⁹ (-3.98%)
Mathlib.AlgebraicGeometry.GammaSpecAdjunction -1.734⬝10⁹ (-0.86%)
2 files, Instructions -5.0⬝10⁹
File Instructions %
Mathlib.AlgebraicGeometry.Morphisms.ClosedImmersion -4.111⬝10⁹ (-9.87%)
Mathlib.AlgebraicGeometry.Morphisms.RingHomProperties -4.423⬝10⁹ (-5.55%)
File Instructions %
Mathlib.AlgebraicGeometry.AffineScheme -15.620⬝10⁹ (-5.92%)
Mathlib.AlgebraicGeometry.AffineSpace -335.926⬝10⁹ (-57.47%)

Copy link
Copy Markdown
Member

@chrisflav chrisflav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some leftovers.

@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 19, 2024
@erdOne erdOne removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 23, 2024
@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 23, 2024
to hide the defeq abuse `f ⁻¹ᵁ ⊤ = ⊤`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2024

Build failed:

@TwoFX
Copy link
Copy Markdown
Member

TwoFX commented Nov 24, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Nov 24, 2024
to hide the defeq abuse `f ⁻¹ᵁ ⊤ = ⊤`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 24, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(AlgebraicGeometry) add Scheme.Hom.appTop [Merged by Bors] - chore(AlgebraicGeometry) add Scheme.Hom.appTop Nov 24, 2024
@mathlib-bors mathlib-bors bot closed this Nov 24, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/appTop branch November 24, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants