Skip to content

[Merged by Bors] - feat(Manifold/IntegralCurve/Transform): pointwise notation and translation lemmas for subtraction#19008

Closed
winstonyin wants to merge 2 commits intomasterfrom
integral_curve_pointwise
Closed

[Merged by Bors] - feat(Manifold/IntegralCurve/Transform): pointwise notation and translation lemmas for subtraction#19008
winstonyin wants to merge 2 commits intomasterfrom
integral_curve_pointwise

Conversation

@winstonyin
Copy link
Copy Markdown
Collaborator

@winstonyin winstonyin commented Nov 14, 2024

We restate the translation lemmas for integral curves using the Pointwise API and add translation lemmas for subtraction for convenience.

This is just split out from #9013.

The Pointwise API allows us to use lemmas like Metric.vadd_ball and more convenient rewriting of the dt term (rather than rewriting it inside the set builder notation).


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 14, 2024

PR summary 85591a7144

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ isIntegralCurveAt_comp_sub
+ isIntegralCurveOn_comp_sub
+ isIntegralCurve_comp_sub

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary

@winstonyin winstonyin changed the title feat(Manifold/IntegralCurve/Transform): pointwise notation and sub lemmas feat(Manifold/IntegralCurve/Transform): pointwise notation and translation lemmas for subtraction Nov 14, 2024
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks good to me - I just wonder if one proof can be simplified.

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Nov 14, 2024

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 14, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 18, 2024

Could you include in the PR description some motivation for this change? I don't really see why it is better; presumably there is some reason given this is split out of another PR!

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 18, 2024

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 18, 2024

✌️ winstonyin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 18, 2024
@grunweg grunweg self-assigned this Nov 18, 2024
@winstonyin
Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Nov 19, 2024
…ation lemmas for subtraction (#19008)

We restate the translation lemmas for integral curves using the `Pointwise` API and add translation lemmas for subtraction for convenience.

This is just split out from #9013.

The `Pointwise` API allows us to use lemmas like `Metric.vadd_ball` and more convenient rewriting of the `dt` term (rather than rewriting it inside the set builder notation).
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 19, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Manifold/IntegralCurve/Transform): pointwise notation and translation lemmas for subtraction [Merged by Bors] - feat(Manifold/IntegralCurve/Transform): pointwise notation and translation lemmas for subtraction Nov 19, 2024
@mathlib-bors mathlib-bors bot closed this Nov 19, 2024
@mathlib-bors mathlib-bors bot deleted the integral_curve_pointwise branch November 19, 2024 00:36
TobiasLeichtfried pushed a commit that referenced this pull request Nov 21, 2024
…ation lemmas for subtraction (#19008)

We restate the translation lemmas for integral curves using the `Pointwise` API and add translation lemmas for subtraction for convenience.

This is just split out from #9013.

The `Pointwise` API allows us to use lemmas like `Metric.vadd_ball` and more convenient rewriting of the `dt` term (rather than rewriting it inside the set builder notation).
mathlib-bors bot pushed a commit that referenced this pull request Nov 27, 2024
…9013)

Lemma 9.15 in Lee's Introduction to Smooth Manifolds:

> Let `v` be a smooth vector field on a smooth manifold `M`. If there exists `ε > 0` such that for each point `x : M`, there exists an integral curve of `v` through `x` defined on an open interval `Ioo (-ε) ε`, then every point on `M` has a global integral curve of `v` passing through it.

We only require `v` to be $C^1$.

To achieve this, we define the extension of an integral curve `γ` by another integral curve `γ'`, if they agree at a point inside their overlapping open interval domains. This utilises the uniqueness theorem of integral curves.

We need this lemma to show that vector fields on compact manifolds always have global integral curves.

- [x] depends on: #8886 
- [x] depends on: #18833
- [x] depends on: #19008



Co-authored-by: Michael Rothgang <rothgang@math.uni-bonn.de>
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-differential-geometry Manifolds etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants