Skip to content

[Merged by Bors] - feat: Port/Data.Finsupp.Fin#1895

Closed
arienmalec wants to merge 8 commits intomasterfrom
port/Data.Finsupp.Fin
Closed

[Merged by Bors] - feat: Port/Data.Finsupp.Fin#1895
arienmalec wants to merge 8 commits intomasterfrom
port/Data.Finsupp.Fin

Conversation

@arienmalec
Copy link
Copy Markdown
Contributor

Port of data.finsupp.fin


Open in Gitpod

Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@arienmalec arienmalec added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jan 27, 2023
@arienmalec arienmalec added awaiting-review and removed WIP Work in progress labels Jan 27, 2023
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@kim-em kim-em added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jan 28, 2023
bors bot pushed a commit that referenced this pull request Jan 28, 2023
Port of data.finsupp.fin
@bors
Copy link
Copy Markdown

bors bot commented Jan 28, 2023

Build failed (retrying...):

  • Build

bors bot pushed a commit that referenced this pull request Jan 28, 2023
Port of data.finsupp.fin
@bors
Copy link
Copy Markdown

bors bot commented Jan 28, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Port/Data.Finsupp.Fin [Merged by Bors] - feat: Port/Data.Finsupp.Fin Jan 28, 2023
@bors bors bot closed this Jan 28, 2023
@bors bors bot deleted the port/Data.Finsupp.Fin branch January 28, 2023 07:32
bors bot pushed a commit that referenced this pull request Feb 15, 2023
`library_search` currently has a bug where it sometimes unnecessarily wraps its output in `namedPattern`.

This PR removes a usage of `namedPattern` that got introduced in #1895, presumably due to the `library_search` bug.
mo271 pushed a commit that referenced this pull request Feb 18, 2023
`library_search` currently has a bug where it sometimes unnecessarily wraps its output in `namedPattern`.

This PR removes a usage of `namedPattern` that got introduced in #1895, presumably due to the `library_search` bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants