Skip to content

[Merged by Bors] - feat(AlgebraicGeometry): preimmersions are stable under base change#18915

Closed
erdOne wants to merge 6 commits intomasterfrom
erd1/surjectiveOnStalks2
Closed

[Merged by Bors] - feat(AlgebraicGeometry): preimmersions are stable under base change#18915
erdOne wants to merge 6 commits intomasterfrom
erd1/surjectiveOnStalks2

Conversation

@erdOne
Copy link
Copy Markdown
Member

@erdOne erdOne commented Nov 12, 2024


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 12, 2024

PR summary 625dd2971c

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.AlgebraicGeometry.Morphisms.Preimmersion 1753 1758 +5 (+0.29%)
Mathlib.AlgebraicGeometry.Morphisms.ClosedImmersion 1785 1787 +2 (+0.11%)
Import changes for all files
Files Import difference
8 files Mathlib.AlgebraicGeometry.Sites.Etale Mathlib.AlgebraicGeometry.Morphisms.Proper Mathlib.AlgebraicGeometry.Morphisms.ClosedImmersion Mathlib.AlgebraicGeometry.Morphisms.Immersion Mathlib.AlgebraicGeometry.Morphisms.Separated Mathlib.AlgebraicGeometry.RationalMap Mathlib.AlgebraicGeometry.SpreadingOut Mathlib.AlgebraicGeometry.Morphisms.UniversallyClosed
2
4 files Mathlib.AlgebraicGeometry.Morphisms.Preimmersion Mathlib.AlgebraicGeometry.ResidueField Mathlib.AlgebraicGeometry.Stalk Mathlib.AlgebraicGeometry.PullbackCarrier
5
Mathlib.AlgebraicGeometry.Morphisms.SurjectiveOnStalks 1756

Declarations diff

+ Cover.exists_eq
+ Hom.homeomorph_apply
+ Spec_iff
+ SurjectiveOnStalks
+ comp
+ eq_stalkwise
+ homeoOfIso_apply
+ homeoOfIso_symm
+ iff_of_isAffine
+ instance (priority := 900) [IsOpenImmersion f] : SurjectiveOnStalks f
+ instance : HasRingHomProperty @SurjectiveOnStalks RingHom.SurjectiveOnStalks
+ instance : IsLocalAtSource @SurjectiveOnStalks
+ instance : IsLocalAtTarget @SurjectiveOnStalks
+ instance : IsStableUnderBaseChange @IsPreimmersion := by
+ instance : MorphismProperty.IsMultiplicative @SurjectiveOnStalks
+ isEmbedding_of_iSup_eq_top_of_preimage_subset_range
+ isEmbedding_pullback
+ of_comp
+ stableUnderBaseChange

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@erdOne erdOne added the WIP Work in progress label Nov 12, 2024
@erdOne erdOne added t-algebraic-geometry Algebraic geometry and removed WIP Work in progress labels Nov 12, 2024
@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 21, 2024

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 21, 2024
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@erdOne
Copy link
Copy Markdown
Member Author

erdOne commented Nov 23, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Nov 23, 2024
…18915)

Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(AlgebraicGeometry): preimmersions are stable under base change [Merged by Bors] - feat(AlgebraicGeometry): preimmersions are stable under base change Nov 23, 2024
@mathlib-bors mathlib-bors bot closed this Nov 23, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/surjectiveOnStalks2 branch November 23, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants