Skip to content

[Merged by Bors] - feat(Topology/ShrinkingLemma): add a predicate on refined open sets#18827

Closed
yoh-tanimoto wants to merge 6 commits intomasterfrom
yoh-tanimoto-PRp
Closed

[Merged by Bors] - feat(Topology/ShrinkingLemma): add a predicate on refined open sets#18827
yoh-tanimoto wants to merge 6 commits intomasterfrom
yoh-tanimoto-PRp

Conversation

@yoh-tanimoto
Copy link
Copy Markdown
Collaborator

add a predicate p : Set X → Prop for PartialRefinent. All the existing theorems remain valid by taking fun _ => True as p.

motivation: with this we can require that the refined open set has a compact closure, by taking fun w => IsCompact (closure w) as p. This can be applied when X is locally compact and T2, and we can obtain a PartitionOfUnity for an open cover of a compact set. (This will be done in #12266)

This splits from #12266

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 10, 2024

PR summary 83b03acab4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ instance : CoeFun (PartialRefinement u s p) fun _ => ι → Set X := ⟨toFun⟩
+ instance : PartialOrder (PartialRefinement u s p)
- instance : CoeFun (PartialRefinement u s) fun _ => ι → Set X := ⟨toFun⟩
- instance : PartialOrder (PartialRefinement u s)

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 11, 2024
yoh-tanimoto and others added 4 commits November 12, 2024 15:55
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@yoh-tanimoto yoh-tanimoto added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Nov 12, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Nov 12, 2024
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer delegate

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 12, 2024
@j-loreaux
Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 12, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 12, 2024
…18827)

add a predicate `p : Set X  → Prop` for `PartialRefinent`. All the existing theorems remain valid by taking `fun _ => True` as `p`.

motivation: with this we can require that the refined open set has a compact closure, by taking `fun w => IsCompact (closure w)` as `p`. This can be applied when X is locally compact and T2, and we can obtain a `PartitionOfUnity` for an open cover of a compact set. (This will be done in #12266)

This splits from #12266 

Co-authored-by: Yoh Tanimoto <57562556+yoh-tanimoto@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Topology/ShrinkingLemma): add a predicate on refined open sets [Merged by Bors] - feat(Topology/ShrinkingLemma): add a predicate on refined open sets Nov 12, 2024
@mathlib-bors mathlib-bors bot closed this Nov 12, 2024
@mathlib-bors mathlib-bors bot deleted the yoh-tanimoto-PRp branch November 12, 2024 16:56
TobiasLeichtfried pushed a commit that referenced this pull request Nov 21, 2024
…18827)

add a predicate `p : Set X  → Prop` for `PartialRefinent`. All the existing theorems remain valid by taking `fun _ => True` as `p`.

motivation: with this we can require that the refined open set has a compact closure, by taking `fun w => IsCompact (closure w)` as `p`. This can be applied when X is locally compact and T2, and we can obtain a `PartitionOfUnity` for an open cover of a compact set. (This will be done in #12266)

This splits from #12266 

Co-authored-by: Yoh Tanimoto <57562556+yoh-tanimoto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants