Skip to content

[Merged by Bors] - feat(bench_summary): report no significant changes and job_id#18812

Closed
adomani wants to merge 16 commits intomasterfrom
adomani/improve_messaging_bench_action
Closed

[Merged by Bors] - feat(bench_summary): report no significant changes and job_id#18812
adomani wants to merge 16 commits intomasterfrom
adomani/improve_messaging_bench_action

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Nov 10, 2024 •
edited
Loading

If the !bench summary contains no entry with a difference in instructions of at least 10^9, then the bot posts a message confirming this information, rather than silently failing.

The bot also posts a link to the workflow CI run that generated the message.

Open in Gitpod

@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Nov 10, 2024

Here are the benchmark results for commit b559fb5.
There were no significant changes against commit b696b35.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 10, 2024 •
edited
Loading

PR summary 4671bbb7fd

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the CI Modifies the continuous integration setup or other automation label Nov 10, 2024
@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Nov 10, 2024

Here are the benchmark results for commit b559fb5.
There were no significant changes against commit b696b35.

@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Nov 10, 2024

Here are the benchmark results for commit b559fb5.
There were no significant changes against commit b696b35.

@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Nov 10, 2024

Here are the benchmark results for commit b559fb5.
There were no significant changes against commit b696b35.

@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Nov 10, 2024

No benchmark entry differed by at least +1.0⬝10⁹ instructions.

@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Nov 10, 2024

Here are the benchmark results for commit b559fb5.
There were no significant changes against commit b696b35.

@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Nov 10, 2024

No benchmark entry differed by at least +1.0⬝10⁹ instructions.

@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Nov 10, 2024

Here are the benchmark results for commit b559fb5.
There were no significant changes against commit b696b35.

@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Nov 10, 2024

No benchmark entry differed by at least +1.0⬝10⁹ instructions.
CI run

@adomani adomani marked this pull request as ready for review November 10, 2024 15:38
joneugster
joneugster approved these changes Nov 24, 2024
View reviewed changes
@joneugster
Copy link
Copy Markdown
Contributor

joneugster commented Nov 24, 2024

LGTM! Thank you

maintainer delegate

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 24, 2024

🚀 Pull request has been placed on the maintainer queue by joneugster.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 24, 2024
@jcommelin jcommelin changed the title feat(bench summary): report no significant changes and job_id feat(bench_summary): report no significant changes and job_id Nov 25, 2024
@jcommelin
Copy link
Copy Markdown
Member

jcommelin commented Nov 25, 2024

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 25, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 25, 2024
@adomani
feat(bench_summary): report no significant changes and job_id (#18812)
aa050b4 
If the `!bench` summary contains no entry with a difference in instructions of at least 10^9, then the bot posts a message confirming this information, rather than silently failing.

The bot also posts a link to the workflow CI run that generated the message.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(bench_summary): report no significant changes and job_id [Merged by Bors] - feat(bench_summary): report no significant changes and job_id Nov 25, 2024
@mathlib-bors mathlib-bors bot closed this Nov 25, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/improve_messaging_bench_action branch November 25, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joneugster joneugster joneugster approved these changes

Assignees

No one assigned

Labels

CI Modifies the continuous integration setup or other automation maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adomani @joneugster @jcommelin