[Merged by Bors] - chore: generalize {Mul, Add}EquivClass.map_{eq, ne}_one_iff#18809
Closed
astrainfinita wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore: generalize {Mul, Add}EquivClass.map_{eq, ne}_one_iff#18809astrainfinita wants to merge 3 commits intomasterfrom
{Mul, Add}EquivClass.map_{eq, ne}_one_iff#18809astrainfinita wants to merge 3 commits intomasterfrom
Conversation
Collaborator
astrainfinita
commented
Nov 10, 2024
PR summary ffad7db041Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
1 task
{Mul/Add}EquivClass.map_{eq/ne}_one_iff{Mul, Add}EquivClass.map_{eq, ne}_one_iff
urkud
reviewed
Nov 11, 2024
| namespace EquivLike | ||
|
|
||
| @[to_additive (attr := simp)] | ||
| theorem map_eq_one_iff {M N} [One M] [One N] [EquivLike F M N] [OneHomClass F M N] |
Member
There was a problem hiding this comment.
Should we use simp on _root_.map_eq_one_iff? Also, should this be generalized to EmbeddingLike?
Ruben-VandeVelde
approved these changes
Nov 11, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Seems reasonable
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Contributor
|
Build failed (retrying...): |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
{Mul, Add}EquivClass.map_{eq, ne}_one_iff{Mul, Add}EquivClass.map_{eq, ne}_one_iff
alreadydone
reviewed
Nov 13, 2024
Comment on lines
+48
to
+52
| @[to_additive (attr := deprecated (since := "2024-11-10"))] | ||
| alias MulEquivClass.map_eq_one_iff := EmbeddingLike.map_eq_one_iff | ||
|
|
||
| @[to_additive (attr := deprecated (since := "2024-11-10"))] | ||
| alias MulEquivClass.map_ne_one_iff := EmbeddingLike.map_ne_one_iff |
Contributor
There was a problem hiding this comment.
These need to be moved down below the def of MulEquivClass as in 36bca67 in order for to_additive to not translate it to MulEquivClass.map_eq/ne_zero_iff.
TobiasLeichtfried
pushed a commit
that referenced
this pull request
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.