Skip to content

[Merged by Bors] - feat(AlgebraicGeometry): the domain of definition of a rational map#18803

Closed
erdOne wants to merge 8 commits intomasterfrom
erd1/rationalMapDomain
Closed

[Merged by Bors] - feat(AlgebraicGeometry): the domain of definition of a rational map#18803
erdOne wants to merge 8 commits intomasterfrom
erd1/rationalMapDomain

Conversation

@erdOne
Copy link
Copy Markdown
Member

@erdOne erdOne commented Nov 9, 2024


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2024

PR summary 075f8f0ba1

Import changes exceeding 2%

% File
+7.40% Mathlib.AlgebraicGeometry.RationalMap

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.AlgebraicGeometry.RationalMap 1838 1974 +136 (+7.40%)
Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.RationalMap 136

Declarations diff

+ Hom.isOver_iff
+ Opens.isDominant_homOfLE
+ Opens.isDominant_ι
+ PartialMap.IsOver
+ PartialMap.exists_restrict_isOver
+ PartialMap.isOver_toRationalMap_iff_of_isSeparated
+ PartialMap.le_domain_toRationalMap
+ PartialMap.toPartialMap_toRationalMap_restrict
+ RationalMap.IsOver
+ RationalMap.dense_domain
+ RationalMap.domain
+ RationalMap.equivFunctionFieldOver
+ RationalMap.exists_partialMap_over
+ RationalMap.isOver_iff
+ RationalMap.mem_domain
+ RationalMap.openCoverDomain
+ RationalMap.toPartialMap
+ RationalMap.toRationalMap_toPartialMap
+ equiv_iff_of_domain_eq_of_isSeparated
+ equiv_iff_of_isSeparated
+ equiv_iff_of_isSeparated_of_le
+ equiv_toPartialMap_iff_of_isSeparated
+ ext_of_isDominant_of_isSeparated'
+ instance (U : X.Opens) : U.ι.IsOver X
+ instance (U : X.Opens) [IsReduced X] : IsReduced U := isReduced_of_isOpenImmersion U.ι
+ instance : IsIso (S ↘ S) := inferInstanceAs (IsIso (𝟙 S))
+ instance : OverClass X X := ⟨𝟙 _⟩
+ instance [IsReduced X] [Y.IsSeparated] [S.IsSeparated] [X.Over S] [Y.Over S]
+ instance [OverClass X S] : HomIsOver (𝟙 X) S
+ instance [OverClass X S] : IsOverTower X S S
+ instance [OverClass X S] : IsOverTower X X S
+ instance [OverClass X S] [OverClass Y S] [OverClass Z S]
+ instance [X.Over S] [Y.Over S] (f : X ⟶ Y) [f.IsOver S] : f.toPartialMap.IsOver S
+ instance [X.Over S] [Y.Over S] (f : X.PartialMap Y) [f.IsOver S]
+ instance [X.Over S] [Y.Over S] (f : X.PartialMap Y) [f.IsOver S] : f.toRationalMap.IsOver S
+ instance [X.Over S] [Y.Over S] [Z.Over S] (f : X ⤏ Y) (g : Y ⟶ Z)
+ instance [X.Over S] [Y.Over S] [Z.Over S] (f : X.PartialMap Y) (g : Y ⟶ Z)
+ instance {U V : X.Opens} (h : U ≤ V) : (X.homOfLE h).IsOver X
+ instance {X : Scheme} : Subsingleton (X.Over (⊤_ Scheme))
+ instance {X Y : Scheme.{u}} [X.Over (⊤_ Scheme)] [Y.Over (⊤_ Scheme)] (f : X ⟶ Y) :
+ isOver_iff
+ isOver_iff_eq_restrict
+ isPullback_opens_inf
+ isPullback_opens_inf_le
- instance (priority := 100) : OverClass X X := ⟨𝟙 _⟩
- instance : U.toScheme.Over X := ⟨U.ι⟩
- instance {X Y : Scheme.{u}} (f : X ⟶ Y) : f.IsOver (⊤_ _) := ⟨terminal.hom_ext _ _⟩

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg changed the title feat(AlgebraicGeoemtry) the domain of definition of a rational map feat(AlgebraicGeometry): the domain of definition of a rational map Nov 10, 2024
@erdOne erdOne added the t-algebraic-geometry Algebraic geometry label Nov 11, 2024
`HomIsOver f S` is the typeclass asserting `f` commutes with the structure morphisms. -/
class HomIsOver (f : X ⟶ Y) (S : C) [OverClass X S] [OverClass Y S] : Prop where
comp_over : f ≫ Y ↘ S = X ↘ S := by simp
comp_over : f ≫ Y ↘ S = X ↘ S := by simp; try rfl
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about by aesop instead of by simp; try rfl?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work!

@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 21, 2024

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 21, 2024
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Nov 23, 2024
@erdOne
Copy link
Copy Markdown
Member Author

erdOne commented Nov 23, 2024

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2024

Build failed:

@erdOne
Copy link
Copy Markdown
Member Author

erdOne commented Nov 23, 2024

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(AlgebraicGeometry): the domain of definition of a rational map [Merged by Bors] - feat(AlgebraicGeometry): the domain of definition of a rational map Nov 23, 2024
@mathlib-bors mathlib-bors bot closed this Nov 23, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/rationalMapDomain branch November 23, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). large-import Automatically added label for PRs with a significant increase in transitive imports t-algebraic-geometry Algebraic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants