[Merged by Bors] - chore(Algebra/InfiniteSum/Order): weaken typeclass assumptions#18742
Closed
[Merged by Bors] - chore(Algebra/InfiniteSum/Order): weaken typeclass assumptions#18742
Conversation
PR summary 0bc1143979Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Generalise the typeclass assumptions on three lemmas, with no other changes. - Remove any assumptions relating the order and the algebra on `hasProd_le_of_prod_le`, also weaken OrderClosedTopology to ClosedIicTopology - Remove any assumptions relating the order and the algebra on `le_hasProd_of_le_prod`, also weaken OrderClosedTopology to ClosedIciTopology - Remove the T2 assumption on `tprod_le_of_prod_range_le`, also weaken OrderClosedTopology to ClosedIicTopology The first two changes mean these lemmas can now be used for infinite products of reals.
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Generalise the typeclass assumptions on three lemmas, with no other changes. - Remove any assumptions relating the order and the algebra on `hasProd_le_of_prod_le`, also weaken OrderClosedTopology to ClosedIicTopology - Remove any assumptions relating the order and the algebra on `le_hasProd_of_le_prod`, also weaken OrderClosedTopology to ClosedIciTopology - Remove the T2 assumption on `tprod_le_of_prod_range_le`, also weaken OrderClosedTopology to ClosedIicTopology The first two changes mean these lemmas can now be used for infinite products of reals.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Jun2M
pushed a commit
that referenced
this pull request
Nov 17, 2024
Generalise the typeclass assumptions on three lemmas, with no other changes. - Remove any assumptions relating the order and the algebra on `hasProd_le_of_prod_le`, also weaken OrderClosedTopology to ClosedIicTopology - Remove any assumptions relating the order and the algebra on `le_hasProd_of_le_prod`, also weaken OrderClosedTopology to ClosedIciTopology - Remove the T2 assumption on `tprod_le_of_prod_range_le`, also weaken OrderClosedTopology to ClosedIicTopology The first two changes mean these lemmas can now be used for infinite products of reals.
TobiasLeichtfried
pushed a commit
that referenced
this pull request
Nov 21, 2024
Generalise the typeclass assumptions on three lemmas, with no other changes. - Remove any assumptions relating the order and the algebra on `hasProd_le_of_prod_le`, also weaken OrderClosedTopology to ClosedIicTopology - Remove any assumptions relating the order and the algebra on `le_hasProd_of_le_prod`, also weaken OrderClosedTopology to ClosedIciTopology - Remove the T2 assumption on `tprod_le_of_prod_range_le`, also weaken OrderClosedTopology to ClosedIicTopology The first two changes mean these lemmas can now be used for infinite products of reals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalise the typeclass assumptions on three lemmas, with no other changes.
hasProd_le_of_prod_le, also weaken OrderClosedTopology to ClosedIicTopologyle_hasProd_of_le_prod, also weaken OrderClosedTopology to ClosedIciTopologytprod_le_of_prod_range_le, also weaken OrderClosedTopology to ClosedIicTopologyThe first two changes mean these lemmas can now be used for infinite products of reals.