Skip to content

[Merged by Bors] - feat(Algebra/Homology/Embedding): the left homology of an extension of homological complexes#18502

Closed
joelriou wants to merge 12 commits intomasterfrom
algebra-homology-embedding-extend-left-homology
Closed

[Merged by Bors] - feat(Algebra/Homology/Embedding): the left homology of an extension of homological complexes#18502
joelriou wants to merge 12 commits intomasterfrom
algebra-homology-embedding-extend-left-homology

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Oct 31, 2024 •
edited
Loading

Given an embedding e : c.Embedding c', K : HomologicalComplex C c, and degrees such that e.f j = j', we construct a left homology data for K.extend e in degree j' from a left homology data for K in degree j.

Open in Gitpod

@joelriou joelriou added WIP Work in progress t-category-theory Category theory labels Oct 31, 2024
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 31, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 31, 2024 •
edited
Loading

PR summary 49c9666d86

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Homology.Embedding.ExtendHomology (new file) 996

Declarations diff

+ CokernelCofork.isColimitOfIsColimitOfIff
+ CokernelCofork.isColimitOfIsColimitOfIff'
+ KernelFork.isLimitOfIsLimitOfIff
+ KernelFork.isLimitOfIsLimitOfIff'
+ cokernelCofork
+ comp_d_eq_zero_iff
+ isColimitCokernelCofork
+ isLimitKernelFork
+ kernelFork
+ leftHomologyData
+ lift_d_comp_eq_zero_iff
+ lift_d_comp_eq_zero_iff'

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 31, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 31, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 13, 2024
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Nov 13, 2024

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 13, 2024
@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Nov 15, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 15, 2024
@joelriou joelriou mentioned this pull request Nov 18, 2024
Closed
1 task
@joelriou joelriou mentioned this pull request Nov 18, 2024
Closed
2 tasks
@joelriou joelriou removed the WIP Work in progress label Nov 26, 2024
This was referenced Nov 28, 2024
Closed
Closed
Closed
@joelriou joelriou changed the title feat(Algebra/Homology): the left homology of an extension of homological complexes feat(Algebra/Homology/Embedding): the left homology of an extension of homological complexes Nov 28, 2024
This was referenced Nov 28, 2024
Closed
Closed
@joelriou joelriou mentioned this pull request Nov 29, 2024
Closed
15 tasks
dagurtomas
dagurtomas reviewed Nov 29, 2024
View reviewed changes
@dagurtomas
Copy link
Copy Markdown
Contributor

dagurtomas commented Nov 29, 2024

Thanks!

maintainer delegate

@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 29, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 29, 2024

🚀 Pull request has been placed on the maintainer queue by dagurtomas.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 29, 2024
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 29, 2024
jcommelin
jcommelin reviewed Nov 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Nov 29, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 30, 2024
@joelriou
feat(Algebra/Homology/Embedding): the left homology of an extension o…
9bdc1af 
…f homological complexes (#18502)

Given an embedding `e : c.Embedding c'`, `K : HomologicalComplex C c`, and degrees such that `e.f j = j'`, we construct a left homology data for `K.extend e` in degree `j'` from a left homology data for `K` in degree `j`.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Homology/Embedding): the left homology of an extension of homological complexes [Merged by Bors] - feat(Algebra/Homology/Embedding): the left homology of an extension of homological complexes Nov 30, 2024
@mathlib-bors mathlib-bors bot closed this Nov 30, 2024
@mathlib-bors mathlib-bors bot deleted the algebra-homology-embedding-extend-left-homology branch November 30, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

@dagurtomas dagurtomas dagurtomas left review comments

Assignees

No one assigned

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-category-theory Category theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joelriou @mathlib4-dependent-issues-bot @dagurtomas @jcommelin @leanprover-community-bot-assistant