Skip to content

[Merged by Bors] - feat(Algebra/Homology): the stupid truncation of homological complexes#18501

Closed
joelriou wants to merge 5 commits intomasterfrom
algebra-homology-embedding-stupid-trunc
Closed

[Merged by Bors] - feat(Algebra/Homology): the stupid truncation of homological complexes#18501
joelriou wants to merge 5 commits intomasterfrom
algebra-homology-embedding-stupid-trunc

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Oct 31, 2024 •
edited
Loading

Note about the large-import label: I believe we may safely ignore it here. In order to develop the basic theory of truncations, we need to import some bits of homology theory at some point which is what is happening here...

Open in Gitpod

@joelriou joelriou added WIP Work in progress t-category-theory Category theory labels Oct 31, 2024
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Oct 31, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 31, 2024 •
edited
Loading

PR summary 3d1385cf46

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
4 files Mathlib.Algebra.Homology.Embedding.HomEquiv Mathlib.Algebra.Homology.Embedding.Extend Mathlib.Algebra.Homology.Embedding.ExtendHomology Mathlib.Algebra.Homology.Embedding.TruncGE
 1
Mathlib.Algebra.Homology.Embedding.StupidTrunc (new file) 971

Declarations diff

+ instance : (K.extend e).IsStrictlySupported e
+ instance : IsStrictlySupported (K.stupidTrunc e) e := by
+ instance {ι'' : Type*} {c'' : ComplexShape ι''} (e' : c''.Embedding c')
+ isZero_stupidTrunc_X
+ isZero_stupidTrunc_iff
+ stupidTrunc
+ stupidTruncFunctor
+ stupidTruncMap
+ stupidTruncMap_comp
+ stupidTruncMap_id
+ stupidTruncMap_stupidTruncXIso_hom
+ stupidTruncXIso

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 31, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 31, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 13, 2024
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

mathlib4-dependent-issues-bot commented Nov 13, 2024

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 13, 2024
@joelriou joelriou removed the WIP Work in progress label Nov 15, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 15, 2024
jcommelin
jcommelin reviewed Dec 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 20, 2024

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Dec 20, 2024
@github-actions github-actions bot removed the large-import Automatically added label for PRs with a significant increase in transitive imports label Dec 20, 2024
@joelriou joelriou mentioned this pull request Dec 20, 2024
Closed
2 tasks
@joelriou
Copy link
Copy Markdown
Contributor Author

joelriou commented Dec 20, 2024

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 20, 2024
@joelriou
feat(Algebra/Homology): the stupid truncation of homological complexes (
74c027f 
#18501)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Homology): the stupid truncation of homological complexes [Merged by Bors] - feat(Algebra/Homology): the stupid truncation of homological complexes Dec 20, 2024
@mathlib-bors mathlib-bors bot closed this Dec 20, 2024
@mathlib-bors mathlib-bors bot deleted the algebra-homology-embedding-stupid-trunc branch December 20, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-category-theory Category theory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joelriou @mathlib4-dependent-issues-bot @jcommelin @leanprover-community-bot-assistant