Skip to content

[Merged by Bors] - feat: IsCoprime.wronskian_eq_zero_iff#18483

Closed
seewoo5 wants to merge 4 commits intomasterfrom
feature/wronskian-coprime
Closed

[Merged by Bors] - feat: IsCoprime.wronskian_eq_zero_iff#18483
seewoo5 wants to merge 4 commits intomasterfrom
feature/wronskian-coprime

Conversation

@seewoo5
Copy link
Copy Markdown
Collaborator

@seewoo5 seewoo5 commented Oct 31, 2024

Add IsCoprime.wronskian_eq_zero_iff: For two polynomials $a, b \in k[x]$ over a field, $W(a, b) = 0$ if and only if $a' = b' = 0$. This is a part of PR #15706.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 31, 2024

PR summary 0eb11e529c

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.Polynomial.Wronskian 978 979 +1 (+0.10%)
Import changes for all files
Files Import difference
Mathlib.RingTheory.Polynomial.Wronskian 1

Declarations diff

+ IsCoprime.wronskian_eq_zero_iff
+ dvd_derivative_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Oct 31, 2024
@seewoo5 seewoo5 self-assigned this Nov 4, 2024
@seewoo5 seewoo5 requested review from YaelDillies and adomani and removed request for adomani November 5, 2024 22:38
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 5, 2024
@seewoo5 seewoo5 removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 6, 2024
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 6, 2024

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 6, 2024
@riccardobrasca
Copy link
Copy Markdown
Member

There are a couple of unaddressed comments, but otherwise LGTM, thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 6, 2024

✌️ seewoo5 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Nov 6, 2024
@seewoo5
Copy link
Copy Markdown
Collaborator Author

seewoo5 commented Nov 6, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Nov 6, 2024
Add `IsCoprime.wronskian_eq_zero_iff`: For two polynomials $a, b \in k[x]$ over a field, $W(a, b) = 0$ if and only if $a' = b' = 0$. This is a part of PR #15706.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: IsCoprime.wronskian_eq_zero_iff [Merged by Bors] - feat: IsCoprime.wronskian_eq_zero_iff Nov 6, 2024
@mathlib-bors mathlib-bors bot closed this Nov 6, 2024
@mathlib-bors mathlib-bors bot deleted the feature/wronskian-coprime branch November 6, 2024 09:15
TobiasLeichtfried pushed a commit that referenced this pull request Nov 21, 2024
Add `IsCoprime.wronskian_eq_zero_iff`: For two polynomials $a, b \in k[x]$ over a field, $W(a, b) = 0$ if and only if $a' = b' = 0$. This is a part of PR #15706.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants