[Merged by Bors] - refactor: generalize SMul (Ideal R) (Submodule R M) to SMul (Submodule R A) (Submodule R M)#18419
Closed
alreadydone wants to merge 32 commits intomasterfrom
Closed
[Merged by Bors] - refactor: generalize SMul (Ideal R) (Submodule R M) to SMul (Submodule R A) (Submodule R M)#18419alreadydone wants to merge 32 commits intomasterfrom
SMul (Ideal R) (Submodule R M) to SMul (Submodule R A) (Submodule R M)#18419alreadydone wants to merge 32 commits intomasterfrom
Conversation
…to noncommutative setting
4 tasks
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 6546fad. Benchmark Metric Change
================================================================
- ~Mathlib.Algebra.Algebra.Operations instructions 20.6%
- ~Mathlib.RingTheory.AdicCompletion.Basic instructions 12.6%
+ ~Mathlib.RingTheory.Ideal.Cotangent instructions -17.6%
+ ~Mathlib.RingTheory.Kaehler.Basic instructions -4.9% |
2 files, Instructions +8.0⬝10⁹
3 files, Instructions +2.0⬝10⁹
4 files, Instructions +1.0⬝10⁹
2 files, Instructions -18.0⬝10⁹
|
Member
|
Can you please merge master and bench again? |
88396b7 to
d81cc44
Compare
d81cc44 to
d3c5b98
Compare
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit d81cc44. Benchmark Metric Change
===========================================================
- ~Mathlib.Algebra.Algebra.Operations instructions 15.7%
+ ~Mathlib.RingTheory.Ideal.Cotangent instructions -18.2%
+ ~Mathlib.RingTheory.Kaehler.Basic instructions -5.3% |
Contributor
Author
|
Hmm, looks like a rather positive change! |
Collaborator
|
Here are the benchmark results for commit d3c5b98. Benchmark Metric Change
===========================================================
- ~Mathlib.Algebra.Algebra.Operations instructions 15.7%
+ ~Mathlib.RingTheory.Ideal.Cotangent instructions -18.2%
+ ~Mathlib.RingTheory.Kaehler.Basic instructions -5.3% |
Contributor
Author
Sorry, false alarm. The sped-up files were changed to avoid timeouts. Let me single those out to a separate PR ... |
Collaborator
|
This PR/issue depends on: |
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit efe2593. Benchmark Metric Change
===========================================================
- ~Mathlib.Algebra.Algebra.Operations instructions 15.7% |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…dule R A) (Submodule R M)` (#18419) and redefine `Mul (Submodule R A) (Submodule R A)` using the latter.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
SMul (Ideal R) (Submodule R M) to SMul (Submodule R A) (Submodule R M)SMul (Ideal R) (Submodule R M) to SMul (Submodule R A) (Submodule R M)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and redefine
Mul (Submodule R A) (Submodule R A)using the latter.Submodule.restrictScalars_meminstead of relying on defeq #19711