Skip to content

[Merged by Bors] - feat(CategoryTheory/Enriched): functoriality of the enrichment of functor categories#18414

Closed
joelriou wants to merge 43 commits intomasterfrom
enriched-category-functor-category-functoriality
Closed

[Merged by Bors] - feat(CategoryTheory/Enriched): functoriality of the enrichment of functor categories#18414
joelriou wants to merge 43 commits intomasterfrom
enriched-category-functor-category-functoriality

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Oct 29, 2024

Let C be a V-enriched ordinary category. Functor categories J ⥤ C have been V-enriched in #18009. Given two functors F₁ and F₂ in J ⥤ C, we use the previous results for functors Under j ⥤ C for all j : J in order to construct functorEnrichedHom V F₁ F₂ : J ⥤ V, and show that the limit of this functor identifies to enrichedHom V F₁ F₂.


Open in Gitpod

joelriou and others added 30 commits October 21, 2024 12:25
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 17, 2024
@joelriou joelriou removed the WIP Work in progress label Nov 17, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 17, 2024
@dagurtomas
Copy link
Copy Markdown
Contributor

@joelriou do you think the erw in this file are really unavoidable? Do you agree that precompEnrichedHom_π is a bad simp lemma as is?

@dagurtomas dagurtomas added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 16, 2024
@joelriou
Copy link
Copy Markdown
Contributor Author

@joelriou do you think the erw in this file are really unavoidable? Do you agree that precompEnrichedHom_π is a bad simp lemma as is?

As the internals of some terms are dsimped, I do not see any good way to remove the erw :(

@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 17, 2024
@dagurtomas
Copy link
Copy Markdown
Contributor

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by dagurtomas.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 17, 2024
dsimp
ext j
rw [end_.lift_π, assoc]
erw [end_.lift_π, end_.lift_π]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost all of these new erws involve end_.lift_π, and it looks like those are all applied to precompEnrichedHom composed with end_.π or enrichedHomπ. Would it work to make a lemma for those two cases, so we can use rw instead of erw?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't work, Joël had a lemma precompEnrichedHom_π for the case enrichedHomπ, and I tried the other case, and erw was still required.

@jcommelin
Copy link
Copy Markdown
Member

Thanks 🎉

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Dec 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 20, 2024
…ctor categories (#18414)

Let `C` be a `V`-enriched ordinary category. Functor categories `J ⥤ C` have been `V`-enriched in #18009. Given two functors `F₁` and `F₂` in `J ⥤ C`, we use the previous results for functors `Under j ⥤ C` for all `j : J` in order to construct `functorEnrichedHom V F₁ F₂ : J ⥤ V`, and show that the limit of this functor identifies to `enrichedHom V F₁ F₂`.



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/Enriched): functoriality of the enrichment of functor categories [Merged by Bors] - feat(CategoryTheory/Enriched): functoriality of the enrichment of functor categories Dec 20, 2024
@mathlib-bors mathlib-bors bot closed this Dec 20, 2024
@mathlib-bors mathlib-bors bot deleted the enriched-category-functor-category-functoriality branch December 20, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants