Skip to content

[Merged by Bors] - feat(Algebra/Module): relation between Module.FinitePresentation and Module.Presentation#18408

Closed
joelriou wants to merge 28 commits intomasterfrom
unbundled-module-presentation-finite
Closed

[Merged by Bors] - feat(Algebra/Module): relation between Module.FinitePresentation and Module.Presentation#18408
joelriou wants to merge 28 commits intomasterfrom
unbundled-module-presentation-finite

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Oct 29, 2024

A module is finitely presented (in the sense of Module.Presentation) iff it has a presentation (in the sense of Module.Presentation) with finitely many generators and relations.
The basic API for the presentation of modules is slightly improved: it should be more stable after this PR is merged.


Open in Gitpod

@joelriou joelriou added WIP Work in progress t-algebra Algebra (groups, rings, fields, etc) labels Oct 29, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 29, 2024

PR summary d0d8b8cd3a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Module.Presentation.Finite 1096

Declarations diff

+ fg_iff_exists_finite_generating_family
+ finite
+ finitePresentation
+ finitePresentation_iff_exists_presentation
+ injective_fromQuotient_iff_ker_π_eq_span
+ isPresentation_iff
+ isPresentation_mk
+ range_π
+ surjective_fromQuotient_iff_surjective_π
+ surjective_π_iff_span_eq_top
+ toQuotient_map
+ toQuotient_map_apply
- mapToKer
- mapToKer_coe
- surjective_mapToKer

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@joelriou joelriou changed the title Unbundled module presentation finite feat(Algebra/Module): relation between Module.FinitePresentation and Module.Presentation Oct 29, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 29, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 30, 2024
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 30, 2024
@erdOne
Copy link
Copy Markdown
Member

erdOne commented Nov 2, 2024

LGTM thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 2, 2024

🚀 Pull request has been placed on the maintainer queue by erdOne.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 2, 2024
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Nov 2, 2024
…Module.Presentation (#18408)

A module is finitely presented (in the sense of `Module.Presentation`) iff it has a presentation (in the sense of `Module.Presentation`) with finitely many generators and relations.
The basic API for the presentation of modules is slightly improved: it should be more stable after this PR is merged.



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Module): relation between Module.FinitePresentation and Module.Presentation [Merged by Bors] - feat(Algebra/Module): relation between Module.FinitePresentation and Module.Presentation Nov 2, 2024
@mathlib-bors mathlib-bors bot closed this Nov 2, 2024
@mathlib-bors mathlib-bors bot deleted the unbundled-module-presentation-finite branch November 2, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants