Skip to content

[Merged by Bors] - feat(Algebra/Module): presentation of modules#18295

Closed
joelriou wants to merge 14 commits intomasterfrom
unbundled-module-presentation
Closed

[Merged by Bors] - feat(Algebra/Module): presentation of modules#18295
joelriou wants to merge 14 commits intomasterfrom
unbundled-module-presentation

Conversation

@joelriou
Copy link
Copy Markdown
Contributor

@joelriou joelriou commented Oct 27, 2024 •
edited
Loading

This PR defines a basic API for the description of modules in terms of generators and relations.

Open in Gitpod

@joelriou joelriou added WIP Work in progress t-algebra Algebra (groups, rings, fields, etc) labels Oct 27, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 27, 2024 •
edited
Loading

PR summary 4c36db383d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Module.Presentation.Basic 892

Declarations diff

+ IsPresentation
+ Presentation
+ Quotient
+ Relations
+ Solution
+ desc
+ desc_var
+ exact
+ fromQuotient
+ fromQuotient_comp_toQuotient
+ fromQuotient_mk
+ ker_toQuotient
+ ker_π
+ linearEquiv
+ linearEquiv_apply
+ linearEquiv_symm_var
+ linearMapEquiv
+ map
+ mapToKer
+ mapToKer_coe
+ map_single
+ ofQuotient
+ ofQuotient_fromQuotient
+ ofQuotient_isPresentation
+ ofQuotient_π
+ ofπ
+ ofπ'
+ ofπ'_π
+ ofπ_π
+ postcomp
+ postcomp_injective
+ range_map
+ span_relation_le_ker_π
+ surjective_mapToKer
+ surjective_toQuotient
+ surjective_π
+ toQuotient
+ toQuotient_relation
+ π
+ π_comp_map
+ π_comp_map_apply
+ π_relation
+ π_single

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@joelriou joelriou removed the WIP Work in progress label Oct 27, 2024
erdOne
erdOne reviewed Oct 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!
Some feature request & design choice questions.

@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 27, 2024
@joelriou
Copy link
Copy Markdown
Contributor Author

joelriou commented Oct 27, 2024

Thanks very much @erdOne for the review!

@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 27, 2024
erdOne
erdOne reviewed Oct 28, 2024
View reviewed changes
erdOne
erdOne reviewed Oct 28, 2024
View reviewed changes
@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 28, 2024
@joelriou joelriou removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 28, 2024
@erdOne
Copy link
Copy Markdown
Member

erdOne commented Oct 28, 2024

LGTM
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2024

🚀 Pull request has been placed on the maintainer queue by erdOne.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 28, 2024
This was referenced Oct 28, 2024
Closed
Closed
jcommelin
jcommelin reviewed Oct 28, 2024
View reviewed changes
jcommelin
jcommelin reviewed Oct 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left 1 comment

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 28, 2024

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Oct 28, 2024
@joelriou
Copy link
Copy Markdown
Contributor Author

joelriou commented Oct 28, 2024

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 28, 2024
@joelriou
feat(Algebra/Module): presentation of modules (#18295)
ed81cec 
This PR defines a basic API for the description of modules in terms of generators and relations.



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Module): presentation of modules [Merged by Bors] - feat(Algebra/Module): presentation of modules Oct 28, 2024
@mathlib-bors mathlib-bors bot closed this Oct 28, 2024
@mathlib-bors mathlib-bors bot deleted the unbundled-module-presentation branch October 28, 2024 13:41
jcommelin pushed a commit that referenced this pull request Oct 29, 2024
@joelriou @jcommelin
feat(Algebra/Module): presentation of modules (#18295)
cd13be6 
This PR defines a basic API for the description of modules in terms of generators and relations.



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
mathlib-bors bot pushed a commit that referenced this pull request Oct 30, 2024
@joelriou
feat(Algebra/Module): characterizations of free modules in terms of t…
3977332 
…heir presentations (#18327)

In this PR, the API for the presentations of modules is slightly developed (uniqueness up to a linear equivalence of the module defined by generators and relations, constructor for the property `IsPresentation`), and this is used to show that a module is free iff it admits a presentation with generators and no relation.

- [x] depends on: #18295



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
grunweg pushed a commit that referenced this pull request Nov 2, 2024
@joelriou @grunweg
feat(Algebra/Module): characterizations of free modules in terms of t…
b125721 
…heir presentations (#18327)

In this PR, the API for the presentations of modules is slightly developed (uniqueness up to a linear equivalence of the module defined by generators and relations, constructor for the property `IsPresentation`), and this is used to show that a module is free iff it admits a presentation with generators and no relation.

- [x] depends on: #18295



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

@erdOne erdOne erdOne left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joelriou @erdOne @jcommelin