Skip to content

[Merged by Bors] - refactor: generalize AddSubmonoid Mul lemmas to SMul#18278

Closed
alreadydone wants to merge 2 commits intomasterfrom
AddSubmonoid_Mul_to_SMul
Closed

[Merged by Bors] - refactor: generalize AddSubmonoid Mul lemmas to SMul#18278
alreadydone wants to merge 2 commits intomasterfrom
AddSubmonoid_Mul_to_SMul

Conversation

@alreadydone
Copy link
Copy Markdown
Contributor

@alreadydone alreadydone commented Oct 27, 2024

Open in Gitpod

@alreadydone alreadydone added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) labels Oct 27, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 27, 2024

PR summary 4a9681a0eb

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ addSubmonoid_smul_bot
+ addSubmonoid_smul_sup
+ instance [NonUnitalNonAssocSemiring R] : DistribSMul R R
+ smul_iSup
+ smul_le_smul_left
+ smul_le_smul_right
+ smul_subset_smul

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@alreadydone alreadydone mentioned this pull request Oct 27, 2024
Closed
4 tasks
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Oct 27, 2024
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Oct 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 27, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Oct 27, 2024
@jcommelin
Copy link
Copy Markdown
Member

jcommelin commented Oct 28, 2024

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 28, 2024
@alreadydone
refactor: generalize AddSubmonoid Mul lemmas to SMul (#18278)
95c5f3f
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Oct 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: generalize AddSubmonoid Mul lemmas to SMul [Merged by Bors] - refactor: generalize AddSubmonoid Mul lemmas to SMul Oct 28, 2024
@mathlib-bors mathlib-bors bot closed this Oct 28, 2024
@mathlib-bors mathlib-bors bot deleted the AddSubmonoid_Mul_to_SMul branch October 28, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees

No one assigned

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alreadydone @jcommelin @Ruben-VandeVelde