[Merged by Bors] - feat(SetTheory/Ordinal/Basic): notation typeLT α = type (α := α) (· < ·)#18235
Closed
[Merged by Bors] - feat(SetTheory/Ordinal/Basic): notation typeLT α = type (α := α) (· < ·)#18235
typeLT α = type (α := α) (· < ·)#18235Conversation
PR summary ea7ecf3dcdImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
YaelDillies
reviewed
Nov 19, 2024
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
Sure
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Contributor
|
Thanks! bors merge |
Contributor
|
Merge conflict. |
2 tasks
Contributor
|
bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
typeLT α = type (α := α) (· < ·)typeLT α = type (α := α) (· < ·)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another option might be to simply make the type argument in
typeexplicit, but since the API makes a lot of use of unbundled relations, that would just make a lot of code longer.This might also make sense to have for
typein, but currently we usetypein (α := o.toType) (· < ·)a lot when we should be usingOrdinal.enumIsoToTypeinstead, so I'd like to clean that up before seeing if introducing notation makes sense.