[Merged by Bors] - chore: add #align statements for to_additive decls#1816
Closed
[Merged by Bors] - chore: add #align statements for to_additive decls#1816
Conversation
Member
jcommelin
commented
Jan 24, 2023
fpvandoorn
reviewed
Jan 24, 2023
Member
fpvandoorn
left a comment
There was a problem hiding this comment.
This is clearly good, and should be merged quickly once it compiles.
bors d+
| #align set.image2_vadd Set.image2_vadd | ||
|
|
||
| @[to_additive add_image_prod] | ||
| -- @[to_additive add_image_prod] -- Porting note: bug in mathlib3 |
Member
There was a problem hiding this comment.
This inserts a translation to an existing but unrelated declaration? We should probably make this @[to_additive vadd_image_prod] if that works
| simpa only [add_comm, div_mul_cancel'] using map_mul_le_add f (a / b) b | ||
| #align le_map_add_map_div le_map_add_map_div | ||
| #align le_map_add_map_sub le_map_add_map_sub | ||
| -- #align le_map_add_map_sub le_map_add_map_sub -- Porting note: TODO: `to_additive` clashes |
Member
There was a problem hiding this comment.
Oh, these are two declarations with the same additive version? Yeah, that happens sometimes.
|
✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with |
1 task
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
alexkeizer
pushed a commit
that referenced
this pull request
Jan 25, 2023
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.